Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-cli): fix typo in diagnostic template info #32684

Closed
wants to merge 1 commit into from

Conversation

@cRAN-cg
Copy link
Contributor

commented Sep 15, 2019

Closes #32662.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: 32662

What is the new behavior?

Explicit context reference error now reads
The template context does not define a member called

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@cRAN-cg cRAN-cg requested a review from angular/fw-compiler as a code owner Sep 15, 2019
@googlebot googlebot added the cla: yes label Sep 15, 2019
@cRAN-cg cRAN-cg force-pushed the cRAN-cg:issue#32662 branch from 2ed700d to e8ed284 Sep 15, 2019
@cRAN-cg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

@gkalpak can you please review.

@cRAN-cg cRAN-cg requested a review from angular/tools-language-service as a code owner Sep 15, 2019
@cRAN-cg cRAN-cg force-pushed the cRAN-cg:issue#32662 branch 2 times, most recently from c0a97ec to e9ae21d Sep 15, 2019
@cRAN-cg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

There seems to be some Chrome version mismatch which is responsible for failing some checks.
Also I had to make three commits to make a workable PR, need your advise if you would like me to squish it into one or submit a new PR itself.

@gkalpak

This comment has been minimized.

Copy link
Member

commented Sep 15, 2019

Thx, @cRAN-cg 🎉
Can you please rebase on latest master (that should make CI green) and squash the commits into one. While you're at it, please also update the commit message to include Fixes #32662 (per our guidelines) 🙏

@cRAN-cg cRAN-cg force-pushed the cRAN-cg:issue#32662 branch 2 times, most recently from 95ade0b to e3ce203 Sep 15, 2019
@cRAN-cg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 15, 2019

@gkalpak Thanks a ton for guiding me. Apologies for not abiding by the guidelines. Will keep that in mind for the next time. It's my first PR to angular so am really very excited  🤩. Thanks for your time and bearing with me. 👍 Thanks again 😊

@gkalpak

This comment has been minimized.

Copy link
Member

commented Sep 16, 2019

No worries, @cRAN-cg! Thx for fixing it up 👍
It looks good to me, but someone from the fw-compiler and tools-language-service team needs to approve it too.

(BTW, test(language-service): fix typo in diagnostic template info. could be removed from the commit message, but is not a blocker.)

@cRAN-cg cRAN-cg force-pushed the cRAN-cg:issue#32662 branch from e3ce203 to 488a5ad Sep 16, 2019
@cRAN-cg

This comment has been minimized.

Copy link
Contributor Author

commented Sep 16, 2019

(BTW, test(language-service): fix typo in diagnostic template info. could be removed from the commit message, but is not a blocker.)

Done sire 🛠

@kara
kara approved these changes Sep 16, 2019
Copy link
Contributor

left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

commented Sep 16, 2019

merge-assistance: global approval

@kara kara closed this in f6d6667 Sep 16, 2019
kara added a commit that referenced this pull request Sep 16, 2019
arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.