Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): ng_package(data) should support non-text files #32721

Closed
wants to merge 1 commit into from

Conversation

@jbedard
Copy link
Contributor

commented Sep 17, 2019

Today non-text ng_package(data) files might (always?) get corrupted because they get read+written as utf8, for example font or image files.

I think the utf8 will be used by default for non-binary files, so the param is not needed at all?

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

The bazel ng_package(data) now supports non-utf8 files.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@jbedard jbedard requested a review from angular/tools-bazel as a code owner Sep 17, 2019
@googlebot googlebot added the cla: yes label Sep 17, 2019
Copy link
Contributor

left a comment

awesome, nice job finding a way to test it

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

@jbedard thanks for the PR! Could you please have a look at the lint error here:

https://circleci.com/gh/angular/angular/459499

Thank you.

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

@alexeagle should this PR go into master only or master and patch?

@jbedard jbedard force-pushed the jbedard:ng_package-data-binary branch from a674a85 to a83c4fd Sep 17, 2019
@jbedard

This comment has been minimized.

Copy link
Contributor Author

commented Sep 17, 2019

Fixed 🤞

Would be great if this was in a patch release...

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

Thanks @jbedard and @alexeagle, this PR is now merged into master and patch branches.

arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.