Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): ensure that `window.ng` utilities are published when NgModules are used #32725

Closed
wants to merge 1 commit into from

Conversation

@matsko
Copy link
Member

commented Sep 17, 2019

Prior to this patch if any backwards-compatible Angular code was using
Ivy then the built-in window.ng debug utilies would not be exposed.

@matsko matsko requested a review from angular/fw-core as a code owner Sep 17, 2019
@googlebot googlebot added the cla: yes label Sep 17, 2019
Copy link
Member

left a comment

lgtm, but could you please add a simple test into application_ref_integration_spec.ts? thanks!

…les are used

Prior to this patch if any backwards-compatible Angular code was using
Ivy then the built-in `window.ng` debug utilies would not be exposed.
@matsko matsko force-pushed the matsko:window_ng_fixes branch from 4d92635 to 42868e9 Sep 17, 2019
@ngbot ngbot bot modified the milestone: needsTriage Sep 17, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

commented Sep 17, 2019

FYI, VE and Ivy presubmits look normal. Thank you.

// included into Angular when PRE mode is active.
export function publishDefaultGlobalUtils__PRE_R3__() {}
export function publishDefaultGlobalUtils__POST_R3__() {
ngDevMode && _publishDefaultGlobalUtils();

This comment has been minimized.

Copy link
@alan-agius4

alan-agius4 Sep 19, 2019

Contributor

We should check if ngDevMode is undefined to avoid possible ReferenceErrors when not using Angular with the CLI directly.

See: #32079

arnehoek added a commit to arnehoek/angular that referenced this pull request Sep 26, 2019
…les are used (angular#32725)

Prior to this patch if any backwards-compatible Angular code was using
Ivy then the built-in `window.ng` debug utilies would not be exposed.

PR Close angular#32725
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.