Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): R3TestBed should clean up registered modules after each test #32872

Closed
wants to merge 2 commits into from

Conversation

@atscott
Copy link
Contributor

atscott commented Sep 27, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

TestBed does not reset the registered modules after each test. Some tests can fail if they are depending on some custom deferred loading module system that: 1. attempts to load the module and if it fails, force compilation and 2. overrideProviders on the module with different values in different tests. The current behavior is that after the first registration, the module is never reregistered so its overrides don't work after the first run.

Does this PR introduce a breaking change?

  • Yes
  • No
@atscott atscott requested a review from angular/fw-core as a code owner Sep 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Sep 27, 2019
@googlebot googlebot added the cla: yes label Sep 27, 2019
@AndrewKushnir AndrewKushnir self-assigned this Sep 27, 2019
@atscott atscott force-pushed the atscott:clearModules branch from c1c41f9 to d9be9b8 Sep 27, 2019
@atscott

This comment has been minimized.

Copy link
Contributor Author

atscott commented Sep 27, 2019

Presubmit
Ivy Presubmit
I want to run a global Ivy presubmit tonight just to be sure this change is good to go.

Copy link
Contributor

AndrewKushnir left a comment

LGTM 👍

@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Sep 30, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "google3" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@atscott atscott closed this in 475e36a Sep 30, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Oct 31, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.