Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): Only restore registered modules if user compiles modules wi… #32944

Closed
wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

atscott commented Oct 1, 2019

…th TestBed

There are a couple scenarios that are problematic and need special
handling:

  1. A user has a custom implementation of lazy-loaded modules, sets some
    provider overrides, then compiles the module so it can be loaded. In a
    follow-up test, the user sets different overrides for the module and
    then compiles. This is problematic because we need to be sure the module
    registered in the first test is not used, so we need to clear it out of
    the modules list in ng_module_factory_registration.
  2. A user has a similar lazy-loaded module factory implementation but
    relies on the module being registered automatically. This can happen,
    for example, as a side effect of importing the ngfactory file.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No
@atscott atscott requested a review from angular/fw-core as a code owner Oct 1, 2019
@ngbot ngbot bot added this to the needsTriage milestone Oct 1, 2019
@googlebot googlebot added the cla: yes label Oct 1, 2019
@atscott

This comment has been minimized.

Copy link
Contributor Author

atscott commented Oct 1, 2019

@atscott atscott force-pushed the atscott:clearModules branch 4 times, most recently from 7f21bb6 to f72f64c Oct 1, 2019
Copy link
Contributor

AndrewKushnir left a comment

LGTM (just one nit) 👍

@atscott atscott removed the PR state: WIP label Oct 1, 2019
@atscott atscott force-pushed the atscott:clearModules branch from f72f64c to e2afaef Oct 1, 2019
…th TestBed

There are a couple scenarios that are problematic and need special
handling:

1. A user has a custom implementation of lazy-loaded modules, sets some
provider overrides, then compiles the module so it can be loaded. In a
follow-up test, the user sets different overrides for the module and
then compiles. This is problematic because we need to be sure the module
registered in the first test is not used, so we need to clear it out of
the modules list in `ng_module_factory_registration`.
2. A user has a similar lazy-loaded module factory implementation but
relies on the module being registered automatically. This can happen,
for example, as a side effect of importing the ngfactory file.
@atscott atscott force-pushed the atscott:clearModules branch from e2afaef to ae210e7 Oct 1, 2019
@atscott atscott closed this in 63256b5 Oct 2, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Nov 2, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.