Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(ivy): Only restore registered modules if user compiles modules wi… #32944
There are a couple scenarios that are problematic and need special
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
…th TestBed There are a couple scenarios that are problematic and need special handling: 1. A user has a custom implementation of lazy-loaded modules, sets some provider overrides, then compiles the module so it can be loaded. In a follow-up test, the user sets different overrides for the module and then compiles. This is problematic because we need to be sure the module registered in the first test is not used, so we need to clear it out of the modules list in `ng_module_factory_registration`. 2. A user has a similar lazy-loaded module factory implementation but relies on the module being registered automatically. This can happen, for example, as a side effect of importing the ngfactory file.
This issue has been automatically locked due to inactivity.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.