Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Directive instantiate minor improvements #33102

Conversation

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Oct 11, 2019

A set of small changes that collectively account for ~11% improvement (~305ms -> ~270ms) on the directive_instantiate benchmark.

Based on the results of the `directive_instantiate` executing host
bindings logic (in creation mode) account for ~23% of time spent in
the directive instantiation, even if a directive doesn't have host
bindings! This is clearly wastful hence a new flag.
@googlebot

This comment has been minimized.

Copy link

googlebot commented Oct 11, 2019

☹️ Sorry, but only Googlers may change the label cla: yes.

@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Oct 11, 2019
@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Oct 11, 2019
@kara
kara approved these changes Oct 11, 2019
Copy link
Contributor

kara left a comment

LGTM

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Oct 11, 2019

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Oct 11, 2019

merge-assistance: looks like unrelated failures in Ivy presubmit

@mhevery mhevery closed this in b800b88 Oct 11, 2019
mhevery added a commit that referenced this pull request Oct 11, 2019
Based on the results of the `directive_instantiate` executing host
bindings logic (in creation mode) account for ~23% of time spent in
the directive instantiation, even if a directive doesn't have host
bindings! This is clearly wastful hence a new flag.

PR Close #33102
ODAVING added a commit to ODAVING/angular that referenced this pull request Oct 18, 2019
ODAVING added a commit to ODAVING/angular that referenced this pull request Oct 18, 2019
ODAVING added a commit to ODAVING/angular that referenced this pull request Oct 18, 2019
)

Based on the results of the `directive_instantiate` executing host
bindings logic (in creation mode) account for ~23% of time spent in
the directive instantiation, even if a directive doesn't have host
bindings! This is clearly wastful hence a new flag.

PR Close angular#33102
AndrusGerman added a commit to AndrusGerman/angular that referenced this pull request Oct 22, 2019
AndrusGerman added a commit to AndrusGerman/angular that referenced this pull request Oct 22, 2019
AndrusGerman added a commit to AndrusGerman/angular that referenced this pull request Oct 22, 2019
)

Based on the results of the `directive_instantiate` executing host
bindings logic (in creation mode) account for ~23% of time spent in
the directive instantiation, even if a directive doesn't have host
bindings! This is clearly wastful hence a new flag.

PR Close angular#33102
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Nov 11, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 11, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.