Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): recompile component when template changes in ngc watch mode #33551

Closed
wants to merge 2 commits into from

Conversation

@JoostK
Copy link
Member

JoostK commented Nov 2, 2019

When the Angular compiler is operated through the ngc binary in watch
mode, changing a template in an external file would not cause the
component to be recompiled if Ivy is enabled.

There was a problem with how a cached compiler host was present that was
unaware of the changed resources, therefore failing to trigger a
recompilation of a component whenever its template changes. This commit
fixes the issue by ensuring that information about modified resources is
correctly available to the cached compiler host.

Fixes #32869

@googlebot googlebot added the cla: yes label Nov 2, 2019
@ngbot ngbot bot modified the milestone: Backlog Nov 2, 2019
@JoostK JoostK marked this pull request as ready for review Nov 2, 2019
@JoostK JoostK requested a review from angular/fw-compiler as a code owner Nov 2, 2019
@alxhub
alxhub approved these changes Nov 6, 2019
@alxhub

This comment has been minimized.

Copy link
Contributor

alxhub commented Nov 6, 2019

Presubmit
No Ivy presubmit needed - this logic is not invoked in g3.

atscott added a commit that referenced this pull request Nov 7, 2019
…#33551)

When the Angular compiler is operated through the ngc binary in watch
mode, changing a template in an external file would not cause the
component to be recompiled if Ivy is enabled.

There was a problem with how a cached compiler host was present that was
unaware of the changed resources, therefore failing to trigger a
recompilation of a component whenever its template changes. This commit
fixes the issue by ensuring that information about modified resources is
correctly available to the cached compiler host.

Fixes #32869

PR Close #33551
@atscott atscott closed this in 8912b11 Nov 7, 2019
atscott added a commit to atscott/angular that referenced this pull request Nov 7, 2019
atscott added a commit to atscott/angular that referenced this pull request Nov 7, 2019
atscott added a commit that referenced this pull request Nov 7, 2019
…atch mode (#33551)" (#33661)

This reverts commit 8912b11.

PR Close #33661
atscott added a commit that referenced this pull request Nov 7, 2019
…atch mode (#33551)" (#33661)

This reverts commit 8912b11.

PR Close #33661
@JoostK JoostK reopened this Nov 7, 2019
When the Angular compiler is operated through the ngc binary in watch
mode, changing a template in an external file would not cause the
component to be recompiled if Ivy is enabled.

There was a problem with how a cached compiler host was present that was
unaware of the changed resources, therefore failing to trigger a
recompilation of a component whenever its template changes. This commit
fixes the issue by ensuring that information about modified resources is
correctly available to the cached compiler host.

Fixes #32869
@JoostK JoostK force-pushed the JoostK:ngc-ivy-template-change branch from 6ab2c38 to af66ff4 Nov 9, 2019
@JoostK JoostK requested a review from angular/dev-infra-framework as a code owner Nov 9, 2019
@JoostK

This comment has been minimized.

Copy link
Member Author

JoostK commented Nov 9, 2019

Windows tests are now passing (https://app.circleci.com/jobs/github/angular/angular/521648) after having enabled Windows tests in this commit, which I have since removed from the PR.

@kara

This comment has been minimized.

Copy link
Contributor

kara commented Nov 12, 2019

kara added a commit that referenced this pull request Nov 12, 2019
…#33551)

When the Angular compiler is operated through the ngc binary in watch
mode, changing a template in an external file would not cause the
component to be recompiled if Ivy is enabled.

There was a problem with how a cached compiler host was present that was
unaware of the changed resources, therefore failing to trigger a
recompilation of a component whenever its template changes. This commit
fixes the issue by ensuring that information about modified resources is
correctly available to the cached compiler host.

Fixes #32869

PR Close #33551
@kara kara closed this in 6899ee5 Nov 12, 2019
JoostK added a commit to JoostK/angular that referenced this pull request Nov 23, 2019
In angular#33551, a bug in `ngc --watch` mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes angular#32869
JoostK added a commit to JoostK/angular that referenced this pull request Nov 24, 2019
In angular#33551, a bug in `ngc --watch` mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes angular#32869
JoostK added a commit to JoostK/angular that referenced this pull request Nov 24, 2019
In angular#33551, a bug in `ngc --watch` mode was fixed so that a component is
recompiled when its template file is changed. Due to insufficient
normalization of files paths, this fix did not have the desired effect
on Windows.

Fixes angular#32869
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Dec 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.