Before node for view

[pkozlowski-opensource]

This is the fix for FW-1559 split into 2 commits:

• tests for (most) cases I could think of (I think that there are more, but couldn't easily reproduce in tests, need more time on those);
• the actual fix - the fix makes the tests pass but results in some code / logic duplication.

This PR is split into 2 commits so we can decide to only take tests or test + fix.

I believe that we should merge it as-is and do the refactoring in the follow-up PR(s).

[mhevery]

There is one more use case. You can have an LContainer but the TNode type is a element. This is because any element can be upgraded into a container. I think we need a test case for that.

[pkozlowski-opensource]

Sure, I can add a test but since views inserted on a VCRef asked on an element are inserted after the element, it shouldn't matter for finding the first node of a view.

In fact I wanted to have a deeper look at the case of a directive asking for a ViwContainerRef on a <ng-container> in a follow-up PR as I'm not sure what will happen for a directive that asks for a ViewContainerRef on a <ng-container>

[pkozlowski-opensource]

Done. Turned out to be super-easy to add those tests so just did it: https://github.com/angular/angular/pull/33627/files#diff-6148157ee1f259b9c8461f23356f0b85R350-R367

[mhevery]

I see, Thank you.

[AndrewKushnir]

Started g3 presubmits to see which targets might be fixed by this PR:

• VE Presubmit
• Ivy Presubmit

Will run a global TAP tonight as well.

Update: Global TAP Presubmit with Ivy.

// cc @atscott

[mhevery]

I see, Thank you.

[ngbot]

I see that you just added the PR action: merge label, but the following checks are still failing:
     conflicts with base branch "master"
     forbidden labels detected: PR action: review
     status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[AndrewKushnir]

FYI, VE and Ivy Presubmits (including global one) are successful 👍

@pkozlowski-opensource could you plz rebase this PR and resolve a conflict, so this PR is ready to merge? Also quick question: should it be merged to master and patch (it's marked for master only atm)?

Thank you.

[pkozlowski-opensource]

@AndrewKushnir rebased

Also quick question: should it be merged to master and patch (it's marked for master only atm)?

We should get it for both 9.x and 10.x so I guess master & patch?

[atscott]

@AndrewKushnir is investigating some weird things we're seeing in presubmits. This should still be good to merge - he'll remove the blocked label when the investigation is finished.

[AndrewKushnir]

Just confirmed that the numbers are fine. The "blocked" label is removed. Thank you.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}