Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upBefore node for view #33627
Conversation
91f3a28
to
84d8832
|
||
if (tNodeType === TNodeType.Element) { | ||
return getNativeByTNode(tNode, lView); | ||
} else if (tNodeType === TNodeType.Container) { |
This comment has been minimized.
This comment has been minimized.
mhevery
Nov 6, 2019
Member
There is one more use case. You can have an LContainer but the TNode type is a element. This is because any element can be upgraded into a container. I think we need a test case for that.
This comment has been minimized.
This comment has been minimized.
pkozlowski-opensource
Nov 6, 2019
•
Author
Member
Sure, I can add a test but since views inserted on a VCRef asked on an element are inserted after the element, it shouldn't matter for finding the first node of a view.
In fact I wanted to have a deeper look at the case of a directive asking for a ViwContainerRef
on a <ng-container>
in a follow-up PR as I'm not sure what will happen for a directive that asks for a ViewContainerRef
on a <ng-container>
This comment has been minimized.
This comment has been minimized.
pkozlowski-opensource
Nov 6, 2019
Author
Member
Done. Turned out to be super-easy to add those tests so just did it: https://github.com/angular/angular/pull/33627/files#diff-6148157ee1f259b9c8461f23356f0b85R350-R367
This comment has been minimized.
This comment has been minimized.
b05ce00
to
2784ff8
This comment has been minimized.
This comment has been minimized.
Started g3 presubmits to see which targets might be fixed by this PR: Will run a global TAP tonight as well. Update: Global TAP Presubmit with Ivy. // cc @atscott |
|
||
if (tNodeType === TNodeType.Element) { | ||
return getNativeByTNode(tNode, lView); | ||
} else if (tNodeType === TNodeType.Container) { |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
ngbot
bot
commented
Nov 6, 2019
This comment has been minimized.
This comment has been minimized.
FYI, VE and Ivy Presubmits (including global one) are successful @pkozlowski-opensource could you plz rebase this PR and resolve a conflict, so this PR is ready to merge? Also quick question: should it be merged to master and patch (it's marked for master only atm)? Thank you. |
2784ff8
to
4ad57b4
This comment has been minimized.
This comment has been minimized.
@AndrewKushnir rebased
We should get it for both 9.x and 10.x so I guess master & patch? |
This comment has been minimized.
This comment has been minimized.
@AndrewKushnir is investigating some weird things we're seeing in presubmits. This should still be good to merge - he'll remove the blocked label when the investigation is finished. |
This comment has been minimized.
This comment has been minimized.
Just confirmed that the numbers are fine. The "blocked" label is removed. Thank you. |
pkozlowski-opensource commentedNov 6, 2019
This is the fix for FW-1559 split into 2 commits:
This PR is split into 2 commits so we can decide to only take tests or test + fix.
I believe that we should merge it as-is and do the refactoring in the follow-up PR(s).