Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Move CLDR dependency to npm #33634

Closed
wants to merge 2 commits into from

Conversation

@josephperrott
Copy link
Member

josephperrott commented Nov 6, 2019

Moves CLDR dependency to npm rather than manually downloading the data in our script.

This caused a change in the formatting on the scripts output, but the actual content is the same.

@googlebot googlebot added the cla: yes label Nov 6, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 6, 2019
@josephperrott josephperrott marked this pull request as ready for review Nov 6, 2019
@josephperrott josephperrott requested review from angular/dev-infra-framework as code owners Nov 6, 2019
Copy link
Member

petebacondarwin left a comment

Did you also update the closure locale file?

@josephperrott

This comment has been minimized.

Copy link
Member Author

josephperrott commented Nov 6, 2019

@petebacondarwin The closure-locale.ts file did not result in any changes.

@gkalpak
gkalpak approved these changes Nov 6, 2019
@atscott atscott closed this in 42d3949 Nov 7, 2019
atscott added a commit that referenced this pull request Nov 7, 2019
atscott added a commit that referenced this pull request Nov 7, 2019
atscott added a commit that referenced this pull request Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.