Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(ivy): recompile component when template changes in ngc wa… #33661

Closed
wants to merge 1 commit into from

Conversation

@atscott
Copy link
Contributor

atscott commented Nov 7, 2019

…tch mode (#33551)"

This reverts commit 8912b11.
CI failure https://app.circleci.com/jobs/github/angular/angular/519284. Reran two additional times and it still failed so it doesn't appear to be a flake

@atscott atscott requested a review from angular/fw-compiler as a code owner Nov 7, 2019
@googlebot googlebot added the cla: yes label Nov 7, 2019
@alxhub
alxhub approved these changes Nov 7, 2019
…atch mode (#33551)"

This reverts commit 8912b11.
@atscott atscott force-pushed the atscott:revert branch from d70d63a to b6b161e Nov 7, 2019
@JoostK

This comment has been minimized.

Copy link
Member

JoostK commented Nov 7, 2019

I am guessing this has something to do with path formats and how the cache is invalidated, there's probably a mismatch. I think I know how to resolve that, will try to enable Windows CI on the PR to be able to verify.

@ngbot ngbot bot added the PR action: merge label Nov 7, 2019
atscott added a commit that referenced this pull request Nov 7, 2019
…atch mode (#33551)" (#33661)

This reverts commit 8912b11.

PR Close #33661
@atscott atscott closed this in 7c5c213 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.