Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upRevert "fix(ivy): recompile component when template changes in ngc wa… #33661
+6
−39
Conversation
This comment has been minimized.
This comment has been minimized.
|
I am guessing this has something to do with path formats and how the cache is invalidated, there's probably a mismatch. I think I know how to resolve that, will try to enable Windows CI on the PR to be able to verify. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
atscott commentedNov 7, 2019
•
edited
…tch mode (#33551)"
This reverts commit 8912b11.
CI failure https://app.circleci.com/jobs/github/angular/angular/519284. Reran two additional times and it still failed so it doesn't appear to be a flake