Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Resolve template variable in nested scope #33676

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Nov 8, 2019

This commit fixes a bug whereby template variables in nested scope are
not resolved properly and instead are simply typed as any.

PR closes angular/vscode-ng-language-service#144

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from ayazhafiz Nov 8, 2019
@kyliau kyliau requested review from angular/fw-compiler as code owners Nov 8, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 8, 2019
@googlebot googlebot added the cla: yes label Nov 8, 2019
@kyliau kyliau force-pushed the kyliau:nested-ng-for branch 2 times, most recently from 6c5e7a0 to 5295f9e Nov 8, 2019
This commit fixes a bug whereby template variables in nested scope are
not resolved properly and instead are simply typed as `any`.

PR closes angular/vscode-ng-language-service#144
@kyliau kyliau force-pushed the kyliau:nested-ng-for branch from 5295f9e to bf19bca Nov 8, 2019
@mhevery
mhevery approved these changes Nov 8, 2019
@kyliau kyliau changed the title fix(language-service): Resolve template variable in nested ngFor fix(language-service): Resolve template variable in nested scope Nov 8, 2019
@ngbot ngbot bot added the PR action: merge label Nov 8, 2019
@kara

This comment has been minimized.

Copy link
Contributor

kara commented Nov 9, 2019

@mhevery Are you globally approving this?

@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Nov 9, 2019

@mhevery Are you globally approving this?

Yes, but pending @alxhub review

@mhevery mhevery requested a review from alxhub Nov 9, 2019
@alxhub
alxhub approved these changes Nov 11, 2019
@kara kara closed this in 8b91ea5 Nov 12, 2019
kara added a commit that referenced this pull request Nov 12, 2019
)

This commit fixes a bug whereby template variables in nested scope are
not resolved properly and instead are simply typed as `any`.

PR closes angular/vscode-ng-language-service#144

PR Close #33676
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.