Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update jiali's info on collaborator page of angular.io #33698

Closed
wants to merge 1 commit into from

Conversation

@JiaLiPassion
Copy link
Contributor

JiaLiPassion commented Nov 8, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the new behavior?

  1. just realized I should use my name instead of my Github handle on aio collaborator page.
  2. update the current company info because I just change my job.

Does this PR introduce a breaking change?

  • Yes
  • No
@JiaLiPassion JiaLiPassion requested a review from angular/fw-docs-marketing as a code owner Nov 8, 2019
@googlebot googlebot added the cla: yes label Nov 8, 2019
@kara
kara approved these changes Nov 8, 2019
Copy link
Contributor

kara left a comment

LGTM

@ngbot ngbot bot added this to the needsTriage milestone Nov 8, 2019
kara added a commit that referenced this pull request Nov 8, 2019
PR Close #33698
@kara kara closed this in a40103d Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.