Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(common): update locales data to remove � characters #33699

Closed
wants to merge 2 commits into from

Conversation

@josephperrott
Copy link
Member

josephperrott commented Nov 8, 2019

Running clang-format via gulp-clang-format was causing intermittent instances of Unicode's replacement character (\uFFFD/�). By running clang-format via shelljs in the gulp script, this intermittent difference is no longer occurring.

Unblocks #33682

@josephperrott josephperrott requested review from angular/dev-infra-framework as code owners Nov 8, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 8, 2019
@googlebot googlebot added the cla: yes label Nov 8, 2019
Copy link
Member

IgorMinar left a comment

sanity restored! thanks for figuring it out

@josephperrott josephperrott referenced this pull request Nov 8, 2019
3 of 12 tasks complete
@doom777

This comment has been minimized.

Copy link
Contributor

doom777 commented Nov 9, 2019

glad that the outcome is good, but overall why is running clang from yarn from shell from shelljs from gulp, good and produces good outcome, but running clang from gulp, bad? I think that the problem is that clang from gulp was not pulling in the correct config

@doom777

This comment has been minimized.

Copy link
Contributor

doom777 commented Nov 10, 2019

Also, it seems that gulp-clang-format is an angular library. It's a shame to abandon it

Edit: looking at the issues, it seems that @IgorMinar was struggling with a similar issue 4(!) years ago

@kara kara closed this in 6cb9988 Nov 11, 2019
kara added a commit that referenced this pull request Nov 11, 2019
kara added a commit that referenced this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.