Transplant views refactor #33702

mhevery · 2019-11-08T23:14:44Z

Based on #33644 (please ignore during review)

PR Checklist

Please check if your PR fulfills the following requirements:

The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit
Tests for the changes have been added (for bug fixes / features)
Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

Bugfix/Performance
Feature
Code style update (formatting, local variables)
Refactoring (no functional changes, no api changes)
Build related changes
CI related changes
Documentation content changes
angular.io application / infrastructure changes
Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

Yes
No

Other information

pkozlowski-opensource · 2019-11-11T06:32:21Z

packages/core/test/acceptance/change_detection_spec.ts

+      myTmpl !: TemplateRef<any>;
+      name: string = 'world';
+      get nameWithLog() {
+        if (ivyEnabled && !getCheckNoChangesMode()) {


I would personally prefer that we write those tests without being ivy specific and without digging into ivy internals. Such tests are brittle and we are not sure that we've got 1:1 behaviour with VE.

Couldn't we assert that the both interpolations are updated in the moved embedded view?

Good point. I tried to do this, but I have failed. I believe that is because the two actually behave differently. I believe the way VE solves this is that when you project a transplanted view which is not on-push it will force the component to on-push. This is in contrast to this PR which CDs the embedded view twice. Once in Declared component (always)and once inInserted` only when marked dirty. Happy to discuss this more.

pkozlowski-opensource · 2019-11-11T06:37:05Z

packages/core/src/render3/instructions/shared.ts

+        const declaredComponentLView = findComponentView(lView);
+        for (let i = 0; i < movedViews.length; i++) {
+          const movedLView = movedViews[i] !;
+          let parentLView = movedLView[PARENT];


Not sure why we've got the logic of getting a parent and while (isLContainer(parentLView)) here. Shouldn't findComponentView go up the embedded views?

As the very minimum it would be great to add more comments here as the logic here starts to be non-obvious.

I have refactored it to make it more clear. But the short of it is that findComponentView does not cross LContainer boundaries.

pkozlowski-opensource · 2019-11-11T06:40:57Z

packages/core/src/render3/instructions/shared.ts

+          }
+          const insertedComponentLView = findComponentView(parentLView !);
+          const insertionIsOnPush =
+              (insertedComponentLView[FLAGS] & LViewFlags.CheckAlways) !== LViewFlags.CheckAlways;


We are not really determining insertionIsOnPush here but rather than it is not CheckAlways, right?

It is not clear to me if this is intentional but I think that we should add comments + tests to explain what happens depending on the insertion view flags (OnPush, OnPush + marked for check, detatched etc.)

We are not really determining insertionIsOnPush here but rather than it is not CheckAlways, right?

So we don't have on-push flag. The way we mark a view on-push is to set CheckAlways to false. I have updated the comment.

PS: We do have ManualOnPush but that is not the same as OnPush. It is only used for wether a click listener should auto-mark the view dirty.

mhevery · 2019-11-12T18:06:00Z

presubmit
ivy presubmit


        perf(ivy): Improve performance of transplanted views

kara

Like the idea of only searching moved views if the flag is set! Some minor things below

packages/core/src/render3/interfaces/container.ts

packages/core/src/render3/interfaces/view.ts

packages/core/src/render3/instructions/container.ts

packages/core/src/render3/interfaces/view.ts

packages/core/test/acceptance/change_detection_spec.ts

packages/core/src/render3/instructions/shared.ts


        fixup! perf(ivy): Improve performance of transplanted views

Co-Authored-By: Kara <kara@users.noreply.github.com>


        fixup! perf(ivy): Improve performance of transplanted views

Co-Authored-By: Kara <kara@users.noreply.github.com>

googlebot · 2019-11-13T23:50:02Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.


        fixup! perf(ivy): Improve performance of transplanted views

googlebot · 2019-11-13T23:52:33Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

packages/core/src/render3/instructions/shared.ts

packages/core/src/render3/interfaces/view.ts

packages/core/src/render3/instructions/shared.ts


        fixup! perf(ivy): Improve performance of transplanted views

Co-Authored-By: Kara <kara@users.noreply.github.com>

googlebot · 2019-11-14T00:17:06Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

kara

LGTM

googlebot · 2019-11-14T00:23:01Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.


        fixup! perf(ivy): Improve performance of transplanted views

Co-Authored-By: Kara <kara@users.noreply.github.com>

googlebot · 2019-11-14T00:29:31Z

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

googlebot · 2019-11-14T00:31:57Z

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.


        perf(ivy): Improve performance of transplanted views (#33702)

PR Close #33702


        Revert "perf(ivy): Improve performance of transplanted views (angular…

…#33702)" This reverts commit f4cdd35.


        perf(ivy): Improve performance of transplanted views (angular#33702)

PR Close angular#33702

mhevery requested review from angular/fw-core as code owners Nov 8, 2019

googlebot added the cla: yes label Nov 8, 2019

mhevery force-pushed the mhevery:transplant_views_refactor branch from 48256af to 31c1f2e Nov 9, 2019

pkozlowski-opensource reviewed Nov 11, 2019

View changes

kara added comp: core comp: ivy labels Nov 11, 2019

ngbot bot modified the milestone: needsTriage Nov 11, 2019

mhevery force-pushed the mhevery:transplant_views_refactor branch from 81f8ebe to 0e68a2f Nov 12, 2019

mhevery added PR target: master & patch PR action: merge labels Nov 12, 2019

mhevery force-pushed the mhevery:transplant_views_refactor branch from 0e68a2f to cf92ede Nov 12, 2019

kara self-requested a review Nov 12, 2019

kara added the PR action: review label Nov 12, 2019

mhevery mentioned this pull request Nov 12, 2019

fix(ivy): Run ChangeDetection on moved views #33644

Closed

4 of 14 tasks complete

perf(ivy): Improve performance of transplanted views

Loading status checks…

21ed744

mhevery force-pushed the mhevery:transplant_views_refactor branch from e46d7a2 to 21ed744 Nov 13, 2019

kara requested changes Nov 13, 2019

View changes

kara added PR action: cleanup and removed PR action: review labels Nov 13, 2019

mhevery and others added 2 commits Nov 13, 2019

fixup! perf(ivy): Improve performance of transplanted views

Loading status checks…

83c7c03

Co-Authored-By: Kara <kara@users.noreply.github.com>

mhevery removed the PR action: cleanup label Nov 13, 2019

googlebot added cla: no and removed cla: yes labels Nov 13, 2019

fixup! perf(ivy): Improve performance of transplanted views

Loading status checks…

68b9389

mhevery added cla: yes and removed cla: no labels Nov 13, 2019

googlebot added cla: no cla: yes and removed cla: yes cla: no labels Nov 13, 2019

kara reviewed Nov 14, 2019

View changes

googlebot added cla: no and removed cla: yes labels Nov 14, 2019

kara approved these changes Nov 14, 2019

View changes

kara added cla: yes and removed cla: no labels Nov 14, 2019

fixup! perf(ivy): Improve performance of transplanted views

Loading status checks…

7a7951b

Co-Authored-By: Kara <kara@users.noreply.github.com>

googlebot added cla: no and removed cla: yes labels Nov 14, 2019

mhevery added cla: yes and removed cla: no labels Nov 14, 2019

mhevery mentioned this pull request Nov 14, 2019

Remove find component view #33810

Closed

4 of 14 tasks complete

alxhub closed this in f4cdd35 Nov 14, 2019

alxhub added a commit that referenced this pull request Nov 14, 2019

perf(ivy): Improve performance of transplanted views (#33702)

Loading status checks…

a16a57e

PR Close #33702

alxhub added a commit to alxhub/angular that referenced this pull request Nov 14, 2019

Revert "perf(ivy): Improve performance of transplanted views (angular…

af00c94

…#33702)" This reverts commit f4cdd35.

petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Nov 15, 2019

perf(ivy): Improve performance of transplanted views (angular#33702)

f382650

PR Close angular#33702

angular/angular

Transplant views refactor #33702

Transplant views refactor #33702

mhevery commented Nov 8, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

mhevery commented Nov 12, 2019

kara left a comment

This comment has been minimized.

googlebot commented Nov 13, 2019

This comment has been minimized.

googlebot commented Nov 13, 2019

This comment has been minimized.

googlebot commented Nov 14, 2019

kara left a comment

This comment has been minimized.

googlebot commented Nov 14, 2019

This comment has been minimized.

googlebot commented Nov 14, 2019

This comment has been minimized.

googlebot commented Nov 14, 2019

angular/angular

Join GitHub today

Transplant views refactor #33702

Conversation

mhevery commented Nov 8, 2019

PR Checklist

PR Type

What is the current behavior?

What is the new behavior?

Does this PR introduce a breaking change?

Other information

This comment has been minimized.

pkozlowski-opensource Nov 11, 2019

This comment has been minimized.

mhevery Nov 12, 2019

This comment has been minimized.

pkozlowski-opensource Nov 11, 2019

This comment has been minimized.

mhevery Nov 12, 2019

This comment has been minimized.

pkozlowski-opensource Nov 11, 2019

This comment has been minimized.

mhevery Nov 12, 2019

This comment has been minimized.

mhevery commented Nov 12, 2019

kara left a comment

This comment has been minimized.

googlebot commented Nov 13, 2019

This comment has been minimized.

googlebot commented Nov 13, 2019

This comment has been minimized.

googlebot commented Nov 14, 2019

kara left a comment

This comment has been minimized.

googlebot commented Nov 14, 2019

This comment has been minimized.

googlebot commented Nov 14, 2019

This comment has been minimized.

googlebot commented Nov 14, 2019