Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): Find event listeners register using angular fast path. #33707

Closed
wants to merge 1 commit into from

Conversation

@mhevery
Copy link
Member

mhevery commented Nov 9, 2019

Angular sometimes registers events using fast path
which than need to be located correctly by the DebugNode so that
triggerEventHandler works correctly.

Fixes #33687

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #33687

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Angular sometimes registers events using [fast path](https://github.com/angular/angular/blob/1d429b216556911edc4b0675ece4cb9081967155/packages/platform-browser/src/dom/events/dom_events.ts#L142-L195)
which than need to be located correctly by the `DebugNode` so that
`triggerEventHandler` works correctly.

Fixes #33687
@googlebot googlebot added the cla: yes label Nov 9, 2019
@kara kara added the comp: ivy label Nov 11, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 11, 2019
@mhevery

This comment has been minimized.

Copy link
Member Author

mhevery commented Nov 12, 2019

Resolved in #33711

@mhevery mhevery closed this Nov 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.