Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): chain listener instructions #33720

Closed

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 10, 2019

Chains multiple listener instructions on a particular element into a single call which results in less generated code. Also handles listeners on templates, host listeners and synthetic host listeners.

@googlebot googlebot added the cla: yes label Nov 10, 2019
@crisbeto crisbeto force-pushed the crisbeto:FW-1617/listener-instruction-chain branch from 225ee08 to bbc9e9e Nov 10, 2019
@crisbeto crisbeto marked this pull request as ready for review Nov 10, 2019
@crisbeto crisbeto requested review from angular/fw-compiler as code owners Nov 10, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 10, 2019
Copy link
Member

pkozlowski-opensource left a comment

Why not, LGTM for runtime.

results in less generated code

Did you happen to have example numbers from the apps you are working on?

Chains multiple listener instructions on a particular element into a single call which results in less generated code. Also handles listeners on templates, host listeners and synthetic host listeners.
@crisbeto crisbeto force-pushed the crisbeto:FW-1617/listener-instruction-chain branch from bbc9e9e to ef4cde5 Nov 11, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

crisbeto commented Nov 11, 2019

@pkozlowski-opensource I don't have numbers for these changes because I don't have access to my app this week, but the approach is similar to the other chained instructions which showed improvements in bundle size.

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Nov 11, 2019

@kara kara closed this in e31f620 Nov 12, 2019
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Dec 11, 2019
Chains multiple listener instructions on a particular element into a single call which results in less generated code. Also handles listeners on templates, host listeners and synthetic host listeners.

PR Close angular#33720
AndrewKushnir added a commit that referenced this pull request Dec 11, 2019
Chains multiple listener instructions on a particular element into a single call which results in less generated code. Also handles listeners on templates, host listeners and synthetic host listeners.

PR Close #33720

PR Close #34340
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Dec 13, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.