Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): handle non-standard input/output names in template type checking #33741

Closed
wants to merge 1 commit into from

Conversation

@JoostK
Copy link
Member

JoostK commented Nov 11, 2019

The template type checker generates code to check directive inputs and
outputs, whose name may contain characters that can not be used as
identifier in TypeScript. Prior to this change, such names would be
emitted into the generated code as is, resulting in invalid code and
unexpected template type check errors.

This commit fixes the bug by representing the potentially invalid names
as string literal instead of raw identifier.

Fixes #33590

…cking

The template type checker generates code to check directive inputs and
outputs, whose name may contain characters that can not be used as
identifier in TypeScript. Prior to this change, such names would be
emitted into the generated code as is, resulting in invalid code and
unexpected template type check errors.

This commit fixes the bug by representing the potentially invalid names
as string literal instead of raw identifier.

Fixes #33590
@JoostK JoostK force-pushed the JoostK:ngtsc-ttc-nonstandard-props branch from 635f03c to d16a301 Nov 11, 2019
@JoostK JoostK marked this pull request as ready for review Nov 12, 2019
@JoostK JoostK requested a review from angular/fw-compiler as a code owner Nov 12, 2019
@alxhub
alxhub approved these changes Nov 14, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Nov 19, 2019

alxhub added a commit that referenced this pull request Nov 20, 2019
…cking (#33741)

The template type checker generates code to check directive inputs and
outputs, whose name may contain characters that can not be used as
identifier in TypeScript. Prior to this change, such names would be
emitted into the generated code as is, resulting in invalid code and
unexpected template type check errors.

This commit fixes the bug by representing the potentially invalid names
as string literal instead of raw identifier.

Fixes #33590

PR Close #33741
@alxhub alxhub closed this in 70311eb Nov 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.