Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(core): create factory in providerToRecord only when needed #33742

Conversation

@NothingEverHappens
Copy link
Contributor

NothingEverHappens commented Nov 11, 2019

In providerToRecord move creating the factory into a condition which actually needs it to avoid unnecessary creating it

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Refactoring (no functional changes, no api changes)

What is the current behavior?

Factory gets created unnecessary

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • No

Other information

@NothingEverHappens NothingEverHappens requested a review from angular/fw-core as a code owner Nov 11, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 11, 2019

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Nov 11, 2019
@NothingEverHappens NothingEverHappens force-pushed the NothingEverHappens:perf-provider-to-record branch from c309f27 to 0e1ac98 Nov 11, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 11, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 11, 2019
@NothingEverHappens NothingEverHappens force-pushed the NothingEverHappens:perf-provider-to-record branch from 0e1ac98 to 3ac9d16 Nov 11, 2019
In providerToRecord move creating the factory into a condition which
actually needs it to avoid unnecessary creating it
@NothingEverHappens NothingEverHappens force-pushed the NothingEverHappens:perf-provider-to-record branch from 3ac9d16 to 945589a Nov 11, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 11, 2019
@AndrewKushnir AndrewKushnir self-assigned this Nov 11, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Nov 11, 2019

Copy link
Contributor

AndrewKushnir left a comment

LGTM 👍

@AndrewKushnir AndrewKushnir changed the title perf(core): In providerToRecord only create factory when needed perf(core): create factory in providerToRecord only when needed Nov 12, 2019
@AndrewKushnir AndrewKushnir removed their assignment Nov 12, 2019
@kara kara closed this in ccee818 Nov 12, 2019
kara added a commit that referenced this pull request Nov 12, 2019
In providerToRecord move creating the factory into a condition which
actually needs it to avoid unnecessary creating it

PR Close #33742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.