Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): ExpressionChangedAfterItHasBeenCheckedError for SafeValue #33749

Closed
wants to merge 1 commit into from

Conversation

@mhevery
Copy link
Member

mhevery commented Nov 11, 2019

Fix #33448

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@mhevery mhevery requested a review from matsko Nov 11, 2019
@mhevery mhevery requested review from angular/fw-core as code owners Nov 11, 2019
@googlebot googlebot added the cla: yes label Nov 11, 2019
@mhevery mhevery force-pushed the mhevery:issue_33448 branch from 46af0bc to 3b8ce2a Nov 12, 2019
@mhevery

This comment has been minimized.

Copy link
Member Author

mhevery commented Nov 12, 2019

Copy link
Member

IgorMinar left a comment

lgtm, but you might want to handle innerHtml in the same way - currently we ignore/don't check SafeValues there.

packages/core/test/acceptance/styling_spec.ts Outdated Show resolved Hide resolved
Copy link
Member

pkozlowski-opensource left a comment

LGTM after Igor comments are addressed

@mhevery mhevery force-pushed the mhevery:issue_33448 branch from 9c20a06 to 4ea02f3 Nov 14, 2019
@mhevery mhevery removed the request for review from matsko Nov 15, 2019
@alxhub alxhub closed this in f2828a0 Nov 15, 2019
alxhub added a commit that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.