Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(bazel): ng_module should not emit shim files under bazel and Ivy #33765
the node_modules contains rxjs which contains invalid bazel files which break bazel query executed on //...
Under bazel and Ivy we don't need the shim files to be emmited by default. We still need to the shims for blaze however because google3 code imports them. This improves build latency by 1-2 seconds per ng_module target.
I kicked off one more presubmit just to be sure: https://test.corp.google.com/ui#id=OCL:280796455:BASE:282004415:1574449954648:5eb13dcc
change has no impact on ivy in g3
This issue has been automatically locked due to inactivity.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.