fix(ivy): avoid infinite recursion when evaluation source files

[JoostK]

When ngtsc comes across a source file during partial evaluation, it
would determine all exported symbols from that module and evaluate their
values greedily. This greedy evaluation strategy introduces unnecessary
work and can fall into infinite recursion when the evaluation result of
an exported expression would circularly depend on the source file. This
would primarily occur in CommonJS code, where the exports variable can
be used to refer to an exported variable. This variable would be
resolved to the source file itself, thereby greedily evaluating all
exported symbols and thus ending up evaluating the exports variable
again. This variable would be resolved to the source file itself,
thereby greedily evaluating all exported symbols and thus ending u
evaluating the exports variable again. This variable would be
resolved to the source file itself, thereby greedily evaluating all
exported symbols and thus ending up evaluating the exports variable
again. This variable would be resolved to the source file itself,
thereby greedily evaluating all exported symbols and thus ending up
evaluating the exports variable again. This went on for some time
until all stack frames were exhausted.

This commit introduces a ResolvedModule that delays the evaluation of
its exports until they are actually requested. This avoids the circular
dependency when evaluating exports, thereby fixing the issue.

Fix #33734

[VladimirAmiorkov]

What is the simplest way of building an Angular with this PR? I want to test if #33734 is resolved by it.

[JoostK]

@VladimirAmiorkov You can find instructions here on using artifacts from CircleCI for this PR:

https://github.com/angular/angular/blob/master/docs/DEVELOPER.md#getting-packages-from-build-artifacts

[VladimirAmiorkov]

@JoostK

Thanks for this info. Looking at the builds and the note that the artefacts may not be averrable I feel like they already are not. I checked here https://circleci.com/gh/angular/angular/524826#artifacts but cant seem to find any artefacts, that build was 6 days ago so maybe I am late to get them :) . Or maybe I dont have access to the "Artefacts" tab, this is what I see on this PR and all others I have checked.

[gkalpak]

@VladimirAmiorkov, you can find the latest artifacts from this PR here: https://circleci.com/gh/angular/angular/524805#artifacts

_{(Hint: It's the publish_packages_as_artifacts job, not the publish_snapshot job 😉)}

[gkalpak]

(FWIW, I tried this with #33734 and I got a different error, so I guess the "Maximum call stack size exceeded" error is fixed 🎉)

[alxhub]

Presubmit
Ivy Presubmit

[ngbot]

I see that you just added the PR action: merge label, but the following checks are still failing:
     status "ci/angular: size" is failing
     status "google3" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[JoostK]

merge-assistance: size failure is unrelated.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}