Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(language-service): Function alias should be callable #33782
This commit fixes a long standing bug whereby a template variable that
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
It resolves to the type of the method it references.
This PR fixes the happy path. We need to also fix the other case - if type resolution fails, we should produce diagnostics instead of defaulting to the Any type. This means we'll have to match the signature of the caller and the receiver. Will probably do it in another PR.
This commit fixes a long standing bug whereby a template variable that gets initialized to a class method gets resolved to the Any type, thus when it is called the language service produces error "Member X is not callable". PR closes #16643 PR closes angular/vscode-ng-language-service#234 PR Close #33782