Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): support for #id bootstrap selectors #33784

Closed
wants to merge 4 commits into from

Conversation

@mhevery
Copy link
Member

mhevery commented Nov 13, 2019

Fixes: #33485

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@googlebot googlebot added the cla: yes label Nov 13, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 13, 2019
@mhevery mhevery force-pushed the mhevery:issue_33485 branch from 1a11fbf to bbc5dba Nov 13, 2019
@mhevery mhevery marked this pull request as ready for review Nov 13, 2019
@mhevery mhevery requested review from angular/fw-compiler as code owners Nov 13, 2019
@mhevery mhevery requested review from AndrewKushnir and kara Nov 13, 2019
@mhevery

This comment has been minimized.

Copy link
Member Author

mhevery commented Nov 14, 2019

Copy link
Member

pkozlowski-opensource left a comment

LGTM with one nit

@kara
kara approved these changes Nov 14, 2019
Copy link
Contributor

kara left a comment

LGTM, one nit

@@ -57,28 +71,37 @@ export class CssSelector {
let inNot = false;
_SELECTOR_REGEXP.lastIndex = 0;
while (match = _SELECTOR_REGEXP.exec(selector)) {
if (match[1]) {
if (match[SelectorRegexp.NOT]) {

This comment has been minimized.

Copy link
@kara

kara Nov 14, 2019

Contributor

👍 Thanks for cleaning this up. Naming them is much more readable

mhevery and others added 2 commits Nov 14, 2019
Co-Authored-By: Kara <kara@users.noreply.github.com>
@mhevery mhevery removed the request for review from AndrewKushnir Nov 15, 2019
@alxhub alxhub closed this in ab0bcee Nov 15, 2019
alxhub added a commit that referenced this pull request Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.