Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(ivy): avoid using stale cache in TestBed if module overrides are defined #33787
+83
−16
Conversation
…defined NgModule compilation in JIT mode (that is also used in TestBed) caches module scopes on NgModule defs (using `transitiveCompileScopes` field). Module overrides (defined via TestBed.overrideModule) may invalidate this data by adding/removing items in `declarations` list. This commit forces TestBed to recalculate transitive scopes in case module overrides are present, so TestBed always gets the most up-to-date information.
…es are defined
…es are defined
AndrewKushnir
force-pushed the
AndrewKushnir:testbed_override_module
branch
from
fb1f3bc
to
4aa04de
This comment has been minimized.
This comment has been minimized.
alxhub
added a commit
that referenced
this pull request
Nov 20, 2019
…defined (#33787) NgModule compilation in JIT mode (that is also used in TestBed) caches module scopes on NgModule defs (using `transitiveCompileScopes` field). Module overrides (defined via TestBed.overrideModule) may invalidate this data by adding/removing items in `declarations` list. This commit forces TestBed to recalculate transitive scopes in case module overrides are present, so TestBed always gets the most up-to-date information. PR Close #33787
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
AndrewKushnir commentedNov 13, 2019
NgModule compilation in JIT mode (that is also used in TestBed) caches module scopes on NgModule defs (using
transitiveCompileScopesfield). Module overrides (defined via TestBed.overrideModule) may invalidate this data by adding/removing items indeclarationslist. This commit forces TestBed to recalculate transitive scopes in case module overrides are present, so TestBed always gets the most up-to-date information.This PR resolves #33735.
PR Type
What kind of change does this PR introduce?
Does this PR introduce a breaking change?