Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ngcc): add default config for `ng2-dragula` #33797

Closed
wants to merge 1 commit into from

Conversation

@gkalpak
Copy link
Member

gkalpak commented Nov 13, 2019

The dist/ directory has a duplicate package.json pointing to the same files, which (under certain configurations) can causes ngcc to try to process the files twice and fail.

This commit adds a default ngcc config for ng2-dragula to ignore the dist/ entry-point.

Fixes #33718.

The `dist/` directory has a duplicate `package.json` pointing to the
same files, which (under certain configurations) can causes ngcc to try
to process the files twice and fail.

This commit adds a default ngcc config for `ng2-dragula` to ignore the
`dist/` entry-point.

Fixes #33718
@gkalpak gkalpak requested a review from angular/fw-ngcc as a code owner Nov 13, 2019
@googlebot googlebot added the cla: yes label Nov 13, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 13, 2019
// The `dist/` directory has a duplicate `package.json` pointing to the same files, which (under
// certain configurations) can causes ngcc to try to process the files twice and fail.
// Ignore the `dist/` entry-point.
'ng2-dragula': {

This comment has been minimized.

Copy link
@petebacondarwin

petebacondarwin Nov 13, 2019

Member

I guess if they fix it then we add a version range to this config?

This comment has been minimized.

Copy link
@gkalpak

gkalpak Nov 13, 2019

Author Member

Are you indirectly suggesting we add a version range to include up to the currently latest version instead?

This comment has been minimized.

Copy link
@petebacondarwin

petebacondarwin Nov 13, 2019

Member

No - definitely not, since they might release a version that is still broken.
I just think we probably need to add a reminder (somehow) to restrict this config to the broken versions if they do fix it.

This comment has been minimized.

Copy link
@gkalpak

gkalpak Nov 14, 2019

Author Member

I have submitted valor-software/ng2-dragula#981 and added an entry in our tracking spreadsheet to update the config once/if ng2-dragula is fixed.

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 13, 2019

kara added a commit that referenced this pull request Nov 13, 2019
The `dist/` directory has a duplicate `package.json` pointing to the
same files, which (under certain configurations) can causes ngcc to try
to process the files twice and fail.

This commit adds a default ngcc config for `ng2-dragula` to ignore the
`dist/` entry-point.

Fixes #33718

PR Close #33797
@kara kara closed this in 95715fc Nov 13, 2019
@gkalpak gkalpak deleted the gkalpak:fix-ngcc-config-ng2-dragula branch Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.