Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update bazel to v1.1.0 #33813

Closed

Conversation

@devversion
Copy link
Member

devversion commented Nov 14, 2019

Updates Bazel to the latest stable version. Bazel 1.1.0
supposedly fixes a permission bug in Windows. Hence we
should try to update and see if that fixes the bug.

It's generally good to be up to date. See potential bug
fix commit: bazelbuild/bazel@618e5a2.

@googlebot googlebot added the cla: yes label Nov 14, 2019
@devversion devversion force-pushed the devversion:build/update-bazel-1.1.0 branch 2 times, most recently from bd648a5 to dbd11ab Nov 14, 2019
Updates Bazel to the latest stable version. Bazel 1.1.0
supposedly fixes a permission bug in Windows. Hence we
should try to update and see if that fixes the bug.

It's generally good to be up to date. See potential bug
fix commit:
bazelbuild/bazel@618e5a2.
@devversion devversion force-pushed the devversion:build/update-bazel-1.1.0 branch from dbd11ab to 2c2a48c Nov 14, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 14, 2019
@devversion devversion marked this pull request as ready for review Nov 14, 2019
@devversion devversion requested review from angular/dev-infra-framework as code owners Nov 14, 2019
@kyliau

This comment has been minimized.

Copy link
Member

kyliau commented Nov 14, 2019

@devversion Could you also please update this file?

The ng-add schematic for `@angular/bazel` should set up
the latest Bazel version v1.1.0 that contains fixes for
windows. e.g. bazelbuild/bazel@618e5a2
@devversion

This comment has been minimized.

Copy link
Member Author

devversion commented Nov 14, 2019

@kyliau Done. Pushed a separate commit since this separate from build-only changes. Please have another look.

@kyliau
kyliau approved these changes Nov 14, 2019
Copy link
Member

kyliau left a comment

thank you!

Copy link
Member

josephperrott left a comment

LGTM

@alxhub alxhub closed this in fc78c64 Nov 14, 2019
alxhub added a commit that referenced this pull request Nov 14, 2019
The ng-add schematic for `@angular/bazel` should set up
the latest Bazel version v1.1.0 that contains fixes for
windows. e.g. bazelbuild/bazel@618e5a2

PR Close #33813
alxhub added a commit that referenced this pull request Nov 14, 2019
Updates Bazel to the latest stable version. Bazel 1.1.0
supposedly fixes a permission bug in Windows. Hence we
should try to update and see if that fixes the bug.

It's generally good to be up to date. See potential bug
fix commit:
bazelbuild/bazel@618e5a2.

PR Close #33813
alxhub added a commit that referenced this pull request Nov 14, 2019
The ng-add schematic for `@angular/bazel` should set up
the latest Bazel version v1.1.0 that contains fixes for
windows. e.g. bazelbuild/bazel@618e5a2

PR Close #33813
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Nov 15, 2019
Updates Bazel to the latest stable version. Bazel 1.1.0
supposedly fixes a permission bug in Windows. Hence we
should try to update and see if that fixes the bug.

It's generally good to be up to date. See potential bug
fix commit:
bazelbuild/bazel@618e5a2.

PR Close angular#33813
petebacondarwin added a commit to petebacondarwin/angular that referenced this pull request Nov 15, 2019
The ng-add schematic for `@angular/bazel` should set up
the latest Bazel version v1.1.0 that contains fixes for
windows. e.g. bazelbuild/bazel@618e5a2

PR Close angular#33813
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.