Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Provide completions for attribute values #33839

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Nov 15, 2019

This commit fixes a bug whereby completions for attribute values are only
provided for directives that support the micro-syntax format, all other
bindings are ignored.

I'm not sure if this is a regresssion or a bug, because there were no
tests prior to this.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from ayazhafiz Nov 15, 2019
@kyliau kyliau requested a review from angular/tools-language-service as a code owner Nov 15, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 15, 2019
@googlebot googlebot added the cla: yes label Nov 15, 2019
packages/language-service/src/completions.ts Outdated Show resolved Hide resolved
@kyliau kyliau force-pushed the kyliau:attr-value-completion branch from d539a45 to f9600f2 Nov 15, 2019
This commit fixes a bug whereby completions for attribute values are only
provided for directives that support the micro-syntax format, all other
bindings are ignored.

I'm not sure if this is a regresssion or a bug, because there were no
tests prior to this.
@kyliau kyliau force-pushed the kyliau:attr-value-completion branch from f9600f2 to 48441c3 Nov 15, 2019
@kyliau

This comment has been minimized.

Copy link
Member Author

kyliau commented Nov 15, 2019

caretaker: I'm a member of tools-language-service

@alxhub alxhub closed this in 592fd37 Nov 16, 2019
alxhub added a commit that referenced this pull request Nov 16, 2019
This commit fixes a bug whereby completions for attribute values are only
provided for directives that support the micro-syntax format, all other
bindings are ignored.

I'm not sure if this is a regresssion or a bug, because there were no
tests prior to this.

PR Close #33839
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.