Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upɵɵtemplate instruction refactor #33856
+53
−34
Conversation
pkozlowski-opensource
force-pushed the
pkozlowski-opensource:template_refactor
branch
from
994561e
to
ee10286
|
I |
| embeddedTView.queries = tView.queries.embeddedTView(tContainerNode); | ||
| } | ||
| } | ||
| const tNode = tView.firstCreatePass ? |
This comment has been minimized.
This comment has been minimized.
| ngDevMode && assertFirstCreatePass(tView); | ||
| ngDevMode && ngDevMode.firstCreatePass++; | ||
| const tViewConsts = tView.consts; | ||
| // TODO(pk): refactor getOrCreateTNode to have the "create" only version |
This comment has been minimized.
This comment has been minimized.
This refactorings clearly separates the first and subsequent creation execution of the `template` instruction. This approach has the following benefits: - it is clear what happens during the first vs. subsequent executions; - we can avoid several memory reads and checks after the first creation pass (there is measurable performance improvement on various benchmarks); - the template instructions becomes smaller and should become a candidate for optimisations / inlining faster;
pkozlowski-opensource
force-pushed the
pkozlowski-opensource:template_refactor
branch
from
ee10286
to
ca19763
This comment has been minimized.
This comment has been minimized.
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
merge-assistance due to "Pending — Status "google3" is pending" |
This comment has been minimized.
This comment has been minimized.
|
@pkozlowski-opensource VE and Ivy presubmits are successful, I updated the status of the g3 check. Thank you. |
alxhub
added a commit
that referenced
this pull request
Nov 19, 2019
#33856) This refactorings clearly separates the first and subsequent creation execution of the `template` instruction. This approach has the following benefits: - it is clear what happens during the first vs. subsequent executions; - we can avoid several memory reads and checks after the first creation pass (there is measurable performance improvement on various benchmarks); - the template instructions becomes smaller and should become a candidate for optimisations / inlining faster; PR Close #33856
alxhub
added a commit
that referenced
this pull request
Nov 19, 2019
#33856) This refactorings clearly separates the first and subsequent creation execution of the `template` instruction. This approach has the following benefits: - it is clear what happens during the first vs. subsequent executions; - we can avoid several memory reads and checks after the first creation pass (there is measurable performance improvement on various benchmarks); - the template instructions becomes smaller and should become a candidate for optimisations / inlining faster; PR Close #33856
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
pkozlowski-opensource commentedNov 15, 2019
This refactoring clearly separates the first and subsequent creation execution
of the
templateinstruction. This approach has the following benefits:(there is measurable performance improvement on various benchmarks);
for optimisations / inlining faster;