Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Insert parentheses for method completion #33860

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Nov 15, 2019

This commit leverages the insertText field in ts.CompletionEntry to
return a completion text for class methods that includes parentheses.

PR closes angular/vscode-ng-language-service#15

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-language-service as a code owner Nov 15, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 15, 2019
@googlebot googlebot added the cla: yes label Nov 15, 2019
@kyliau kyliau force-pushed the kyliau:insertText branch from edf6247 to 34ea88a Nov 15, 2019
@kyliau kyliau requested a review from angular/fw-integration as a code owner Nov 15, 2019
@kyliau kyliau requested a review from ayazhafiz Nov 15, 2019
Copy link
Member

ayazhafiz left a comment

Is it possible to specify that next insertion index for the user should be between the parentheses?

@kyliau

This comment has been minimized.

Copy link
Member Author

kyliau commented Nov 23, 2019

Is it possible to specify that next insertion index for the user should be between the parentheses?

I don't think it is possible to change the user's cursor. That would be bad user experience, as it would catch users by surprise.

@kyliau kyliau force-pushed the kyliau:insertText branch from 34ea88a to 268490b Nov 23, 2019
@ayazhafiz ayazhafiz requested a review from josephperrott Nov 24, 2019
This commit leverages the `insertText` field in `ts.CompletionEntry` to
return a completion text for class methods that includes parentheses.

PR closes angular/vscode-ng-language-service#15
@kyliau kyliau force-pushed the kyliau:insertText branch from 268490b to 4b4b071 Nov 27, 2019
Copy link
Member

josephperrott left a comment

LGTM

mhevery added a commit that referenced this pull request Dec 3, 2019
This commit leverages the `insertText` field in `ts.CompletionEntry` to
return a completion text for class methods that includes parentheses.

PR closes angular/vscode-ng-language-service#15

PR Close #33860
@mhevery mhevery closed this in dd944ef Dec 3, 2019
@kyliau kyliau deleted the kyliau:insertText branch Dec 3, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 3, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.