Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upperf(ivy): R3TestBed - Do not process NgModuleDefs that have already … #33863
+22
−10
Conversation
This comment has been minimized.
This comment has been minimized.
|
Thanks for the fix @atscott I know PR is still in Draft mode, but I'd propose adding some comments on why we do caching (since we may encounter the same NgModules while going though imports and exports, so we want to avoid re-processing). Otherwise - looks great! |
This comment has been minimized.
This comment has been minimized.
atscott
added
PR action: merge
and removed
PR action: presubmit
PR action: merge
labels
alxhub
added a commit
that referenced
this pull request
Nov 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
atscott commentedNov 15, 2019
•
edited
…been processed
I was observing 10x slower test times in Ivy vs VE and this change made Ivy perform as fast as VE. Perf analysis showed that 96% of the time was spent in
queueTypesFromModulesArray. This can happen with deep trees of imports that have duplicated NgModule imports throughout.