Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
perf(ivy): R3TestBed - Do not process NgModuleDefs that have already … #33863
I was observing 10x slower test times in Ivy vs VE and this change made Ivy perform as fast as VE. Perf analysis showed that 96% of the time was spent in
Thanks for the fix @atscott
I know PR is still in Draft mode, but I'd propose adding some comments on why we do caching (since we may encounter the same NgModules while going though imports and exports, so we want to avoid re-processing). Otherwise - looks great!
This issue has been automatically locked due to inactivity.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.