Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(ivy): reset style property using ngStyle #33920
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #33650
What is the new behavior?
This resolves issue with styles still being present after clearing ngStyle.
Does this PR introduce a breaking change?
Hi @raizemm, thanks for the fix
I've restarted CircleCI tests and they are passing now. It looks like there were some flakes unrelated to the changes in this PR. I've also started g3 presubmits (note: links are internal to Google and they are posted here as a reference for Caretaker):
I also noticed that there are 3 commits in this PR (2 of them are fixes to the first one). Could you please squash them into a single commit?
Once presubmits are "green" (I will update this thread) and commits are squashed, this PR will be ready for merge.