Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): reset style property using ngStyle #33920

Closed
wants to merge 1 commit into from

Conversation

@raizemm
Copy link
Contributor

raizemm commented Nov 19, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: #33650

What is the new behavior?

This resolves issue with styles still being present after clearing ngStyle.
Although this is a small change I think types around ApplyStylingFn value property could be more strict.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@raizemm raizemm requested a review from angular/fw-core as a code owner Nov 19, 2019
@googlebot googlebot added the cla: yes label Nov 19, 2019
@ngbot

This comment has been minimized.

Copy link

ngbot bot commented Nov 19, 2019

I see that you just added the PR action: merge label, but the following checks are still failing:
    failure status "ci/circleci: legacy-unit-tests-saucelabs" is failing
    failure status "ci/circleci: lint" is failing
    pending missing required labels: PR target: *
    pending status "google3" is pending
    pending missing required status "ci/circleci: publish_snapshot"

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@matsko
matsko approved these changes Nov 19, 2019
@matsko
matsko approved these changes Nov 19, 2019
Copy link
Member

matsko left a comment

Please fix the lint issues.

@raizemm

This comment has been minimized.

Copy link
Contributor Author

raizemm commented Nov 19, 2019

@matsko Fixed.

There are still some tests failing but I don't think that these are related to the change.

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Nov 19, 2019

Hi @raizemm, thanks for the fix 👍

I've restarted CircleCI tests and they are passing now. It looks like there were some flakes unrelated to the changes in this PR. I've also started g3 presubmits (note: links are internal to Google and they are posted here as a reference for Caretaker):

I also noticed that there are 3 commits in this PR (2 of them are fixes to the first one). Could you please squash them into a single commit?

Once presubmits are "green" (I will update this thread) and commits are squashed, this PR will be ready for merge.

Thank you.

@raizemm raizemm force-pushed the raizemm:ng-style-clear-styles-fix branch from 537a1c6 to 97a47a6 Nov 20, 2019
@raizemm

This comment has been minimized.

Copy link
Contributor Author

raizemm commented Nov 20, 2019

Hello @AndrewKushnir,

The commits should look good now. Waiting for the presubmits to be "green" :)

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Nov 20, 2019

Hi @raizemm, thanks for squashing commits. The g3 checks are "green", I've updated the status of this PR. I've also restarted failing CIrcleCI jobs, since it's likely to be a flake (that would be fixed in #33937). Once CircleCI is green, this PR should be ready to be merged. Thank you.

alxhub added a commit that referenced this pull request Nov 20, 2019
@alxhub alxhub closed this in 7b4853b Nov 20, 2019
@raizemm raizemm deleted the raizemm:ng-style-clear-styles-fix branch Nov 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.