Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): add flag to skip non-exported classes #33921

Conversation

@crisbeto
Copy link
Member

crisbeto commented Nov 19, 2019

In ViewEngine we were only generating code for exported classes, however with Ivy we do it no matter whether the class has been exported or not. These changes add an extra flag that allows consumers to opt into the ViewEngine behavior. The flag works by treating non-exported classes as if they're set to jit: true.

Fixes #33724.

@googlebot googlebot added the cla: yes label Nov 19, 2019
@crisbeto crisbeto force-pushed the crisbeto:FW-1681/skip-non-exported-classes-option branch 3 times, most recently from 6d05ba8 to 103534d Nov 19, 2019
@ngbot ngbot bot modified the milestone: needsTriage Nov 19, 2019
@crisbeto crisbeto marked this pull request as ready for review Nov 19, 2019
@crisbeto crisbeto requested review from angular/fw-compiler as code owners Nov 19, 2019
@devversion

This comment has been minimized.

Copy link
Member

devversion commented Nov 19, 2019

This PR will close #33724. The issue also provides some context and a reproduction for later reference.

@crisbeto crisbeto force-pushed the crisbeto:FW-1681/skip-non-exported-classes-option branch from 103534d to 6450b4c Nov 19, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

crisbeto commented Nov 19, 2019

The feedback has been addressed.

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Nov 21, 2019

@alxhub
alxhub approved these changes Nov 21, 2019
packages/compiler-cli/src/transformers/api.ts Outdated Show resolved Hide resolved
@crisbeto crisbeto force-pushed the crisbeto:FW-1681/skip-non-exported-classes-option branch from 6450b4c to 0c3f60c Nov 21, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

crisbeto commented Nov 21, 2019

Updated based on the latest set of feedback.

@crisbeto crisbeto force-pushed the crisbeto:FW-1681/skip-non-exported-classes-option branch 2 times, most recently from 741c026 to b3ebfae Nov 21, 2019
@alxhub

This comment has been minimized.

Copy link
Contributor

alxhub commented Nov 21, 2019

Presubmit
Ivy Presubmit: not needed, no a g3 behavior change.

@crisbeto crisbeto force-pushed the crisbeto:FW-1681/skip-non-exported-classes-option branch from b3ebfae to a905e08 Nov 21, 2019
@crisbeto crisbeto changed the title refactor(ivy): add flag to skip non-exported classes fix(ivy): add flag to skip non-exported classes Nov 21, 2019
@alxhub
alxhub approved these changes Nov 21, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor

AndrewKushnir commented Nov 25, 2019

@crisbeto g3 presubmit looks good (I removed the "presubmit" label). Could you please rebase this PR and resolve a conflict? Thank you.

In ViewEngine we were only generating code for exported classes, however with Ivy we do it no matter whether the class has been exported or not. These changes add an extra flag that allows consumers to opt into the ViewEngine behavior. The flag works by treating non-exported classes as if they're set to `jit: true`.

Fixes #33724.
@crisbeto crisbeto force-pushed the crisbeto:FW-1681/skip-non-exported-classes-option branch from a905e08 to de866c6 Nov 25, 2019
@crisbeto

This comment has been minimized.

Copy link
Member Author

crisbeto commented Nov 25, 2019

Rebased.

@matsko matsko closed this in 25dcc76 Nov 25, 2019
AndrewKushnir added a commit to AndrewKushnir/angular that referenced this pull request Dec 11, 2019
In ViewEngine we were only generating code for exported classes, however with Ivy we do it no matter whether the class has been exported or not. These changes add an extra flag that allows consumers to opt into the ViewEngine behavior. The flag works by treating non-exported classes as if they're set to `jit: true`.

Fixes angular#33724.

PR Close angular#33921
AndrewKushnir added a commit that referenced this pull request Dec 11, 2019
In ViewEngine we were only generating code for exported classes, however with Ivy we do it no matter whether the class has been exported or not. These changes add an extra flag that allows consumers to opt into the ViewEngine behavior. The flag works by treating non-exported classes as if they're set to `jit: true`.

Fixes #33724.

PR Close #33921

PR Close #34340
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Dec 26, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
5 participants
You can’t perform that action at this time.