Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(language-service): completions support for tuple array #33928

Closed
wants to merge 2 commits into from

Conversation

@ivanwonder
Copy link
Contributor

ivanwonder commented Nov 20, 2019

implement the missing tuple functionality because the PR #29811 has been closed.
#29811 (comment)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ivanwonder ivanwonder requested a review from angular/tools-language-service as a code owner Nov 20, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 20, 2019

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no label Nov 20, 2019
@ivanwonder ivanwonder force-pushed the ivanwonder:tuple-array branch from 42d9787 to 1558658 Nov 20, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Nov 20, 2019

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Nov 20, 2019
@ayazhafiz ayazhafiz requested a review from kyliau Nov 26, 2019
Copy link
Member

kyliau left a comment

Thank you very much for fixing this!

packages/language-service/src/typescript_symbols.ts Outdated Show resolved Hide resolved
packages/language-service/src/typescript_symbols.ts Outdated Show resolved Hide resolved
@kyliau

This comment has been minimized.

Copy link
Member

kyliau commented Nov 26, 2019

The commit message linter doesn't like the commit messages, could you please squash them all into one?

@ivanwonder

This comment has been minimized.

Copy link
Contributor Author

ivanwonder commented Nov 26, 2019

The commit message linter doesn't like the commit messages, could you please squash them all into one?

ok, I will

@ivanwonder ivanwonder force-pushed the ivanwonder:tuple-array branch 3 times, most recently from cf5ffe4 to 5a258e8 Nov 26, 2019
@ivanwonder ivanwonder requested review from kyliau and ayazhafiz Nov 26, 2019
@ivanwonder ivanwonder force-pushed the ivanwonder:tuple-array branch from 06f6642 to 3f45956 Nov 27, 2019
@ivanwonder ivanwonder force-pushed the ivanwonder:tuple-array branch from 3f45956 to 737c0ab Nov 27, 2019
@kyliau
kyliau approved these changes Nov 27, 2019
Copy link
Member

kyliau left a comment

Thank you so much!

mhevery added a commit that referenced this pull request Nov 27, 2019
mhevery added a commit that referenced this pull request Nov 27, 2019
@ivanwonder

This comment has been minimized.

Copy link
Contributor Author

ivanwonder commented Nov 27, 2019

love the language-service, and hope it better.🤝

@ivanwonder ivanwonder deleted the ivanwonder:tuple-array branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.