Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): remove deprecated and defunct wtf* apis #33949

Closed
wants to merge 2 commits into from

Conversation

@IgorMinar
Copy link
Member

IgorMinar commented Nov 21, 2019

These apis have been deprecated in v8, but since they are defunct we are removing them early so that they don't take up payload size.

Closes #12509

@IgorMinar IgorMinar requested review from angular/fw-core as code owners Nov 21, 2019
@googlebot googlebot added the cla: yes label Nov 21, 2019
@kara
kara approved these changes Nov 21, 2019
Copy link
Contributor

kara left a comment

LGTM

@JiaLiPassion

This comment has been minimized.

Copy link
Contributor

JiaLiPassion commented Nov 21, 2019

These apis have been deprecated in v8, so they should stick around till v10,
but since they are defunct we are removing them early so that they don't take up payload size.
@IgorMinar IgorMinar force-pushed the IgorMinar:core/remove-wtf branch from a266d47 to b6b42b2 Nov 21, 2019
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 21, 2019

@IgorMinar

This comment has been minimized.

Copy link
Member Author

IgorMinar commented Nov 21, 2019

hmm @JiaLiPassion I didn't realize that there was a wtf specific zone spec.

Is anyone using it? this zone spec is separate from exposing the wtf apis so I think it's ok to remove stuff from core, but keep wtf support in zone.js.

@IgorMinar

This comment has been minimized.

Copy link
Member Author

IgorMinar commented Nov 21, 2019

thanks for pointing this out btw

@IgorMinar

This comment has been minimized.

Copy link
Member Author

IgorMinar commented Nov 21, 2019

I'm marking this as blocked until we agree on the zone.js spec story

@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Nov 21, 2019

@IgorMinar

This comment has been minimized.

Copy link
Member Author

IgorMinar commented Nov 21, 2019

looking into this more, I think we should go ahead with this change as is without removing the zone.js integration in ng_zone. That can be done separately in the future.

@IgorMinar

This comment has been minimized.

Copy link
Member Author

IgorMinar commented Nov 21, 2019

merge-assistance: global approval

@matsko

This comment has been minimized.

Copy link
Member

matsko commented Nov 22, 2019

@JiaLiPassion

This comment has been minimized.

Copy link
Contributor

JiaLiPassion commented Nov 22, 2019

@IgorMinar , yeah, sure, there is no harm to leave the wtfZoneSpec in ngZone for now, and I don't think any one are really using it because wtf itself is not continued. Thanks for looking into it.

@matsko matsko closed this in ed55355 Nov 25, 2019
matsko added a commit that referenced this pull request Nov 25, 2019
These apis have been deprecated in v8, so they should stick around till v10,
but since they are defunct we are removing them early so that they don't take up payload size.

PR Close #33949
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.