Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ngcc): report errors from `analyze` and `resolve` processing #33964

Closed

Conversation

@petebacondarwin
Copy link
Member

petebacondarwin commented Nov 21, 2019

Previously, these errors were being swallowed, which made it
hard to debug problems with packages.

See #33685 (comment)

Previously, these errors were being swallowed, which made it
hard to debug problems with packages.

See #33685 (comment)
@gkalpak

This comment has been minimized.

Copy link
Member

gkalpak commented Nov 21, 2019

BTW, the integration size check failure is unrelated (but the linting one needs fixing).

alxhub added a commit that referenced this pull request Nov 21, 2019
)

Previously, these errors were being swallowed, which made it
hard to debug problems with packages.

See #33685 (comment)

PR Close #33964
@alxhub alxhub closed this in 715d02a Nov 21, 2019
@petebacondarwin petebacondarwin deleted the petebacondarwin:ngcc-error-reporting branch Nov 22, 2019
JoostK added a commit to JoostK/ngcc-validation that referenced this pull request Nov 22, 2019
In angular/angular#33964 an issue was fixed
where metadata resolution diagnostics were never reported. This commit
adds projects that are now failing, as reporting the diagnostics
prevents the libraries from building correctly. Note, however, that
these problems are not really new; these packages can not have worked
correctly before.
mgechev added a commit to angular/ngcc-validation that referenced this pull request Nov 23, 2019
In angular/angular#33964 an issue was fixed
where metadata resolution diagnostics were never reported. This commit
adds projects that are now failing, as reporting the diagnostics
prevents the libraries from building correctly. Note, however, that
these problems are not really new; these packages can not have worked
correctly before.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.