Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ngcc): render UMD global imports correctly #34012

Closed

Conversation

@petebacondarwin
Copy link
Member

petebacondarwin commented Nov 23, 2019

The current UMD rendering formatter did not handle
a number of corner cases, such as imports from namespaced
packages.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Contributor

alan-agius4 left a comment

LGTM

Thanks Pete

Copy link
Contributor

alan-agius4 left a comment

See above

The current UMD rendering formatter did not handle
a number of corner cases, such as imports from namespaced
packages.
@petebacondarwin petebacondarwin force-pushed the petebacondarwin:ngcc-umd-rendering-fix branch from fb2ba04 to 2e5772a Nov 23, 2019
@alan-agius4

This comment has been minimized.

Copy link
Contributor

alan-agius4 commented Nov 23, 2019

Just to be clear with the changes made it increases the chance of getting the global id right.

But that don’t guarantee it, because like we change angular to ng so can libraries authors. But I think this would be a very rare case if any.

matsko added a commit that referenced this pull request Nov 25, 2019
The current UMD rendering formatter did not handle
a number of corner cases, such as imports from namespaced
packages.

PR Close #34012
@matsko matsko closed this in 44225e4 Nov 25, 2019
@petebacondarwin petebacondarwin deleted the petebacondarwin:ngcc-umd-rendering-fix branch Nov 25, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Dec 26, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
You can’t perform that action at this time.