Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): take styles extracted from template into account in JIT mode #34017

Closed

Conversation

@AndrewKushnir
Copy link
Contributor

AndrewKushnir commented Nov 23, 2019

Prior to this commit, all styles extracted from Component's template (defined using <style> tags) were ignored by JIT compiler, so only styles array values defined in @component decorator were used. This change updates JIT compiler to take styles extracted from the template into account. It also ensures correct order where styles array values are applied first and template styles are applied second.

This PR resolves FW-1744.

PR Type

What kind of change does this PR introduce?

  • Bugfix

Does this PR introduce a breaking change?

  • Yes
  • No
Prior to this commit, all styles extracted from Component's template (defined using <style> tags) were ignored by JIT compiler, so only `styles` array values defined in @component decorator were used. This change updates JIT compiler to take styles extracted from the template into account. It also ensures correct order where `styles` array values are applied first and template styles are applied second.
@ngbot ngbot bot modified the milestone: needsTriage Nov 23, 2019
@googlebot googlebot added the cla: yes label Nov 23, 2019
@AndrewKushnir AndrewKushnir marked this pull request as ready for review Nov 24, 2019
@AndrewKushnir AndrewKushnir requested review from angular/fw-compiler as code owners Nov 24, 2019
@AndrewKushnir

This comment has been minimized.

Copy link
Contributor Author

AndrewKushnir commented Nov 25, 2019

@AndrewKushnir

This comment has been minimized.

Copy link
Contributor Author

AndrewKushnir commented Nov 25, 2019

Caretaker: using Misko's approval as global (Misko confirmed) to cover for fw-compiler group. Thank you.

matsko added a commit that referenced this pull request Nov 26, 2019
#34017)

Prior to this commit, all styles extracted from Component's template (defined using <style> tags) were ignored by JIT compiler, so only `styles` array values defined in @component decorator were used. This change updates JIT compiler to take styles extracted from the template into account. It also ensures correct order where `styles` array values are applied first and template styles are applied second.

PR Close #34017
@matsko matsko closed this in 5de7960 Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.