Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(ivy): fix creation time micro-benchmarks #34031

Conversation

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Nov 25, 2019

Micro-benchmarks were broken after we've introduced concept of
DECLARATION_COMPONENT_VIEW on LView (after this change embedded
views must have a pointer to a parent LView).

Micro-benchmarks were broken after we've introduced concept of
DECLARATION_COMPONENT_VIEW on LView (after this change embedded
views must have a pointer to a parent LView).
@googlebot googlebot added the cla: yes label Nov 25, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 25, 2019
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Nov 25, 2019
@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Nov 25, 2019
matsko added a commit that referenced this pull request Nov 25, 2019
Micro-benchmarks were broken after we've introduced concept of
DECLARATION_COMPONENT_VIEW on LView (after this change embedded
views must have a pointer to a parent LView).

PR Close #34031
@matsko matsko closed this in 31e2bdf Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.