Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
perf: add js-web-frameworks benchmark #34034
All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.
We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only
Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the
IgorMinar left a comment
I pushed a commit with a few fixes + added a bunch of comments. I find the structure of the app to be hard to follow, but I don't understand what constraints you had to write it this way. I suggest separating code into 4 parts:
Thnx for the review @IgorMinar ! I've addressed smaller issues, but I guess the most important item is:
Totally with you! The only "constraint" I've imposed here was "consistency with the existing benchmarks folders / files structure".
I've opened #34127 so we can clean-up things. My personal preference would be to merge this PR so it matches the existing structure and then do across-the-board cleanup as described in #34127.
In any case we need to coordinate any folder / file moves with the LL setup, if I'm not mistaken?
This issue has been automatically locked due to inactivity.
Read more about our automatic conversation locking policy.
This action has been performed automatically by a bot.