Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): function.bind() should not be an error (#34041) #34046

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Nov 26, 2019

When performing diagnostic checks or completions, we should take into
account members and properties in the base class, if any. Otherwise, the
language service will produce a false error.

PR closes angular/vscode-ng-language-service#93

PR Close #34041

(cherry picked from commit 7cd16b9)

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

When performing diagnostic checks or completions, we should take into
account members and properties in the base class, if any. Otherwise, the
language service will produce a false error.

PR closes angular/vscode-ng-language-service#93

PR Close #34041

(cherry picked from commit 7cd16b9)
@kyliau kyliau requested a review from angular/tools-language-service as a code owner Nov 26, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 26, 2019
@googlebot googlebot added the cla: yes label Nov 26, 2019
matsko added a commit that referenced this pull request Nov 26, 2019
#34046)

When performing diagnostic checks or completions, we should take into
account members and properties in the base class, if any. Otherwise, the
language service will produce a false error.

PR closes angular/vscode-ng-language-service#93

PR Close #34041

(cherry picked from commit 7cd16b9)

PR Close #34046
@matsko

This comment has been minimized.

Copy link
Member

matsko commented Nov 26, 2019

Landed as d22f3d6

@matsko matsko closed this Nov 26, 2019
@kyliau kyliau deleted the kyliau:9.0.x branch Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.