Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Do not produce diagnostics if metadata for NgModule not found #34113

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Nov 27, 2019

The language service incorrectly reports an error if it fails to find
NgModule metadata for a particular Component / Directive. In many cases,
the use case is legit, particularly in test.

This commit removes such diagnostic message and cleans up the interface
for TypeScriptHost.getTemplateAst().

This is a regression in version 9 due to recent refactorings.

PR closes angular/vscode-ng-language-service#463

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@kyliau kyliau requested a review from angular/tools-language-service as a code owner Nov 27, 2019
@googlebot googlebot added the cla: yes label Nov 27, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 27, 2019
@kyliau kyliau requested a review from ayazhafiz Nov 27, 2019
Copy link
Member

ayazhafiz left a comment

Does this mean that the language service will no longer report

packages/language-service/src/template.ts Outdated Show resolved Hide resolved
@kyliau kyliau force-pushed the kyliau:no-metadata-found branch from 09e5dd2 to d4a6d40 Nov 28, 2019
…odule not found

The language service incorrectly reports an error if it fails to find
NgModule metadata for a particular Component / Directive. In many cases,
the use case is legit, particularly in test.

This commit removes such diagnostic message and cleans up the interface
for `TypeScriptHost.getTemplateAst()`.

PR closes angular/vscode-ng-language-service#463
@kyliau kyliau force-pushed the kyliau:no-metadata-found branch from d4a6d40 to 2de00ab Nov 28, 2019
@mhevery mhevery closed this in 39722df Dec 2, 2019
mhevery added a commit that referenced this pull request Dec 2, 2019
…odule not found (#34113)

The language service incorrectly reports an error if it fails to find
NgModule metadata for a particular Component / Directive. In many cases,
the use case is legit, particularly in test.

This commit removes such diagnostic message and cleans up the interface
for `TypeScriptHost.getTemplateAst()`.

PR closes angular/vscode-ng-language-service#463

PR Close #34113
@kyliau kyliau deleted the kyliau:no-metadata-found branch Dec 17, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 17, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 17, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.