Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): Make missing module suggestion instead of error #34115

Closed
wants to merge 1 commit into from

Conversation

@kyliau
Copy link
Member

kyliau commented Nov 28, 2019

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes ng.DiagnosticKind, and instead reuses
ts.DiagnosticCategory.

PR closes angular/vscode-ng-language-service#458

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes `ng.DiagnosticKind`, and instead reuses
`ts.DiagnosticCategory`.

PR closes angular/vscode-ng-language-service#458
@kyliau kyliau requested a review from ayazhafiz Nov 28, 2019
@kyliau kyliau requested a review from angular/tools-language-service as a code owner Nov 28, 2019
@ngbot ngbot bot added this to the needsTriage milestone Nov 28, 2019
@googlebot googlebot added the cla: yes label Nov 28, 2019
@mhevery mhevery closed this in 7eccbcd Dec 2, 2019
@kyliau kyliau deleted the kyliau:diagnostics-warning branch Dec 2, 2019
kyliau added a commit to kyliau/angular that referenced this pull request Dec 2, 2019
angular#34115)

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes `ng.DiagnosticKind`, and instead reuses
`ts.DiagnosticCategory`.

PR closes angular/vscode-ng-language-service#458

PR Close angular#34115

(cherry picked from commit 7eccbcd)
mhevery added a commit that referenced this pull request Dec 3, 2019
#34115) (#34193)

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes `ng.DiagnosticKind`, and instead reuses
`ts.DiagnosticCategory`.

PR closes angular/vscode-ng-language-service#458

PR Close #34115

(cherry picked from commit 7eccbcd)

PR Close #34193
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 2, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.