Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ivy): allow inserting attached views to a different container #34156

Closed

Conversation

@pkozlowski-opensource
Copy link
Member

pkozlowski-opensource commented Nov 29, 2019

This PR fixes #34152
Easier to review commit-by-commit.

@googlebot googlebot added the cla: yes label Nov 29, 2019
@pkozlowski-opensource pkozlowski-opensource force-pushed the pkozlowski-opensource:gh_34152 branch 2 times, most recently from e827087 to 95fffaa Nov 29, 2019
@pkozlowski-opensource pkozlowski-opensource changed the title fix(ivy): allow inserting attached views to a different container - DO NOT MERGE fix(ivy): allow inserting attached views to a different container Dec 2, 2019
@ngbot ngbot bot modified the milestone: needsTriage Dec 2, 2019
@pkozlowski-opensource pkozlowski-opensource marked this pull request as ready for review Dec 2, 2019
@pkozlowski-opensource pkozlowski-opensource requested a review from angular/fw-core as a code owner Dec 2, 2019
@mhevery
mhevery approved these changes Dec 2, 2019
@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 3, 2019

@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 3, 2019

This PR seems to break the g3. The breakage is a screenshoot diff where the UI is missing most of its content, so it seems to be related to this change.

@mhevery

This comment has been minimized.

Copy link
Member

mhevery commented Dec 3, 2019

@mhevery mhevery closed this in 2cf25fa Dec 4, 2019
mhevery added a commit that referenced this pull request Dec 4, 2019
mhevery added a commit that referenced this pull request Dec 4, 2019
mhevery added a commit that referenced this pull request Dec 4, 2019
mhevery added a commit that referenced this pull request Dec 4, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 4, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
4 participants
You can’t perform that action at this time.