Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(common): add camelcase and kebabcase pipes #34175

Closed
wants to merge 1 commit into from

Conversation

@MrJithil
Copy link
Contributor

MrJithil commented Dec 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?
This PR will add 2 new case conversion pipes.

  1. CamelCasePipe
  2. KebabCasePipe
  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@MrJithil MrJithil requested a review from angular/fw-core as a code owner Dec 2, 2019
@googlebot googlebot added the cla: yes label Dec 2, 2019
@MrJithil MrJithil force-pushed the MrJithil:camelCaseAndKebabCasePipes branch 3 times, most recently from b09b27b to 4321c0f Dec 2, 2019
@MrJithil MrJithil requested a review from angular/docs-infra as a code owner Dec 2, 2019
@MrJithil MrJithil force-pushed the MrJithil:camelCaseAndKebabCasePipes branch from 4321c0f to 6fd9db7 Dec 2, 2019
@MrJithil MrJithil changed the title feat(common): camelcase and kebabcase pipes feat(common): add camelcase and kebabcase pipes Dec 2, 2019
@MrJithil MrJithil force-pushed the MrJithil:camelCaseAndKebabCasePipes branch 4 times, most recently from 41f7614 to 7a2a69a Dec 3, 2019
@MrJithil MrJithil force-pushed the MrJithil:camelCaseAndKebabCasePipes branch from 7a2a69a to 6e8a3fd Dec 3, 2019
@MrJithil MrJithil requested a review from angular/fw-public-api as a code owner Dec 3, 2019
@mhevery mhevery added the comp: core label Dec 3, 2019
@ngbot ngbot bot added this to the needsTriage milestone Dec 3, 2019
Copy link
Member

mhevery left a comment

Thanks for the PR.

We discussed this and we don't feel that this belongs into angular. We would like to keep the Angular API surface focused on the most common use cases. This one seems developer specific.

Adding this would enlarge Angular surface area which will be maintenance cost. Given the utility we don't think we want to pay that tax going forward.

We are very sorry, I am sure you put a lot of effort into this.

@mhevery mhevery closed this Dec 3, 2019
@MrJithil

This comment has been minimized.

Copy link
Contributor Author

MrJithil commented Dec 4, 2019

Thanks for the PR.

We discussed this and we don't feel that this belongs into angular. We would like to keep the Angular API surface focused on the most common use cases. This one seems developer specific.

Adding this would enlarge Angular surface area which will be maintenance cost. Given the utility we don't think we want to pay that tax going forward.

We are very sorry, I am sure you put a lot of effort into this.

Thanks 👍

@petebacondarwin

This comment has been minimized.

Copy link
Member

petebacondarwin commented Dec 4, 2019

@MrJithil - this is a perfect case for a 3rd party library. Angular was always designed from the beginning to allow developers to create libraries that provide additional functionality, whether it appears in the form of services, components or (in this case) pipes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.