Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: ng-conf 2020 added #34176

Closed
wants to merge 117 commits into from
Closed

Conversation

@owenmecham
Copy link
Contributor

owenmecham commented Dec 2, 2019

Added ng-conf 2020 marketing info to events and announcements

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe: Marketing section of angular.io

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Added ng-conf 2020 marketing info to events and announcements
@owenmecham owenmecham requested a review from angular/fw-docs-marketing as a code owner Dec 2, 2019
@googlebot googlebot added the cla: yes label Dec 2, 2019
Copy link
Member

gkalpak left a comment

Thx! Left a couple of minor comments.
(BTW, are you involved with the conf organization. If not, we should probably check with the organizing team to make sure thay are happy with the content.)

aio/content/marketing/events.html Outdated Show resolved Hide resolved
aio/content/marketing/announcements.json Outdated Show resolved Hide resolved
"message": "Join us for ng-conf<br/>May 1st-3rd, 2019",
"startDate": "2020-01-01",
"endDate": "2020-03-31",
"message": "Join us for ng-conf<br/>April 1st-3rd, 2020",
"imageUrl": "generated/images/marketing/home/ng-conf.png",

This comment has been minimized.

Copy link
@gkalpak

gkalpak Dec 2, 2019

Member

I wonder if they want to use the existing image.

This comment has been minimized.

Copy link
@owenmecham

owenmecham Dec 2, 2019

Author Contributor

I can supply a new version of the logo for ng-conf 2020 if you can provide the dimensions that you require.

This comment has been minimized.

Copy link
@StephenFluin

StephenFluin Dec 2, 2019

Member

You should replace and use the same dimensions as https://github.com/angular/angular/blob/master/aio/content/images/marketing/home/ng-conf.png (the current image) so it just keeps working.

aio/content/marketing/announcements.json Outdated Show resolved Hide resolved
Updated announcement duration and html formatting
@owenmecham

This comment has been minimized.

Copy link
Contributor Author

owenmecham commented Dec 2, 2019

@gkalpak I am a new member of the ng-conf organizers. Aaron Frost asked me to submit this PR.

"message": "Join us for ng-conf<br/>May 1st-3rd, 2019",
"startDate": "2020-01-01",
"endDate": "2020-03-31",
"message": "Join us for ng-conf<br/>April 1st-3rd, 2020",
"imageUrl": "generated/images/marketing/home/ng-conf.png",

This comment has been minimized.

Copy link
@StephenFluin

StephenFluin Dec 2, 2019

Member

You should replace and use the same dimensions as https://github.com/angular/angular/blob/master/aio/content/images/marketing/home/ng-conf.png (the current image) so it just keeps working.

IgorMinar and others added 17 commits Nov 23, 2019
…json (#34002)

This allows us to update the version of the package in a single place for all tests.

Notable exemption of this is aio which currently doesn't depend on anything installed in the root.

PR Close #34002
none of these files are needed any more as they were replaced by Bazel.

PR Close #34058
we no longer need them.

PR Close #34058
we no longer need it.

PR Close #34058
…ut errors (#34063)

Previously, some RxJS-related examples (which are not proper Angular apps) were not
tested on CI as part of the `example-e2e` npm script. This meant that the examples
could get out-of-date or contain compile errors without as noticing.

This commit ensures that the `example-e2e` script picks up these examples and checks
that they compile successfully.

Partly addresses #28017.

PR Close #34063
* This brings in a fix to the `@npm//foo:foo_files` targets for #33927 so the a rules_nodejs patch can be removed.
* It also brings a protractor_web_test fix that resolves the need for a work-around in /modules/playground/e2e_test/sourcemap/BUILD.bazel.

PR Close #34073
…es (#34089)

Currently, variables of an unknown type in an `*ngFor` expression are
refined to have the type of the iterable binding of the `*ngFor`
expression. Unfortunately, this is a bug for variables aliasing
[values exported by
`*ngFor`](https://angular.io/api/common/NgForOf#local-variables),
including `index` and `first`, because they are also given the type of
the binding expression, but they are not of the binding type. For
example, in

```typescript
@component({
  selector: 'test',
  template: `
    <div *ngFor="let hero of heroes; let i = index; let isFirst = first">
      {{ hero }}
    </div>
  `
})
export class TestComponent {
  heroes: Hero[];
}
```

The local variables `i` and `isFirst` are determined to have a type of
`Hero`, when actually their types are `number` and `boolean`,
respectively.

This commit fixes this bug by checking if the value of a variable in an
`*ngFor` expression is known to be an export and assigning the variable
the type of that export value. Only if the variable does not alias an
export is it typed with the binding value of the `*ngFor` expression.

Closes angular/vscode-ng-language-service#460

PR Close #34089
…with Ivy (#34109)

To inform downstream users to switch to using angular_ivy_enabled as the build
variable for setting Ivy, a deprecation message is printed instructing the user
to migrate away from building with compile=*

PR Close #34109
…lar usage (#34109)

To quicken migration for our own developers away from using compile=aot
for setting ivy, we actually fail the build process if the compile
build variable is used with a message to use our config flags instead.

PR Close #34109
…odule not found (#34113)

The language service incorrectly reports an error if it fails to find
NgModule metadata for a particular Component / Directive. In many cases,
the use case is legit, particularly in test.

This commit removes such diagnostic message and cleans up the interface
for `TypeScriptHost.getTemplateAst()`.

PR closes angular/vscode-ng-language-service#463

PR Close #34113
…34114)

`host.error()` would log to file, and makes error messages much easier
to inspect because entries are time-stamped.

PR Close #34114
#34115)

If a Component or Directive is not part of any NgModule, the language
service currently produces an error message. This should not be an
error. Instead, it should be a suggestion.

This PR removes `ng.DiagnosticKind`, and instead reuses
`ts.DiagnosticCategory`.

PR closes angular/vscode-ng-language-service#458

PR Close #34115
PR Close #34122
The missing-injectable migration has been updated to handle a breaking change that is
unrelated to missing ´@Injectable` decorators. Though, the breaking change will be handled
as part of this migration since we did not want to create another migration (with all the boilerplate etc.)

The guide has been already updated to reflect the new pattern the migration handles, but we
should also rename the title of the guide to something that also mentions the other pattern.

Not renaming the guide URL since it is referenced in past releases and it's safer to keep the old
URL. The important thing is to change the actual rendered title.

PR Close #34125
…tch guide (#34125)

Updates the description of the `missing-injectable` migration to mention the second pattern
that will be automatically handled.

PR Close #34125
@owenmecham owenmecham requested review from angular/fw-compiler as code owners Dec 10, 2019
@googlebot

This comment has been minimized.

Copy link

googlebot commented Dec 10, 2019

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Dec 10, 2019
@kapunahelewong

This comment has been minimized.

Copy link
Contributor

kapunahelewong commented Dec 10, 2019

Hi @owenmecham, a rebase should clear out all those extra commits that aren't part of this PR. You might like these notes on my own workflow. If you need a hand, let me know and I can help you sort it out - I've done this before myself.🙂

EDIT: Oops, this link is probably better. It's on the same page but further down: What to do if you end up with a bunch of commits that aren't yours in your PR

owenmecham added 2 commits Dec 2, 2019
Added ng-conf 2020 marketing info to events and announcements
…m/angular into ng-conf-2020-marketing
@owenmecham

This comment has been minimized.

Copy link
Contributor Author

owenmecham commented Dec 11, 2019

@kapunahelewong I ran through the rebase steps from your process but it appears that this PR is in a bad place now. There are so few changes that it honestly would be faster for me to simply start again on a new branch and abandon this PR and start over.

@owenmecham owenmecham closed this Dec 11, 2019
@owenmecham owenmecham deleted the owenmecham:ng-conf-2020-marketing branch Dec 11, 2019
@kapunahelewong

This comment has been minimized.

Copy link
Contributor

kapunahelewong commented Dec 11, 2019

Aw, ok, @owenmecham. Well, if you run into this again, maybe I can try my hand at it and see if I can sort it out from my end. Please feel free to tag me. 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
docs
In Progress
You can’t perform that action at this time.