Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(language-service): bug of accessing a string index signature using dot notation #34177

Closed
wants to merge 4 commits into from

Conversation

@ivanwonder
Copy link
Contributor

ivanwonder commented Dec 2, 2019

fix bug of the pr #33884 @ayazhafiz

primitiveType: {[name: string]: string} = {};

{{primitiveType.test}} this will produce errors. because the string type doesn't have Symbol.

const symbol = this.stringIndexType.getSymbol();

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@ivanwonder ivanwonder requested a review from angular/tools-language-service as a code owner Dec 2, 2019
@googlebot googlebot added the cla: yes label Dec 2, 2019
@ivanwonder ivanwonder force-pushed the ivanwonder:primitive-type branch from beecd8f to 0c569c9 Dec 2, 2019
@ayazhafiz ayazhafiz requested a review from kyliau Dec 2, 2019
@ngbot ngbot bot added this to the needsTriage milestone Dec 2, 2019
@ivanwonder ivanwonder requested a review from ayazhafiz Dec 3, 2019
Copy link
Member

ayazhafiz left a comment

LGTM, just a couple of typos.

packages/language-service/src/typescript_symbols.ts Outdated Show resolved Hide resolved
packages/language-service/src/typescript_symbols.ts Outdated Show resolved Hide resolved
packages/language-service/src/typescript_symbols.ts Outdated Show resolved Hide resolved
@ivanwonder ivanwonder force-pushed the ivanwonder:primitive-type branch from e3ebbcb to 37fa083 Dec 3, 2019
@ivanwonder ivanwonder requested a review from ayazhafiz Dec 3, 2019
@ayazhafiz

This comment has been minimized.

Copy link
Member

ayazhafiz commented Dec 3, 2019

Thank you!

@ivanwonder ivanwonder requested review from ayazhafiz and kyliau Dec 4, 2019
…PipeSymbol.selectSignature
@ivanwonder ivanwonder force-pushed the ivanwonder:primitive-type branch from 557c2e2 to 9e020ff Dec 4, 2019
@kyliau
kyliau approved these changes Dec 5, 2019
Copy link
Member

kyliau left a comment

Thank you very much @ivanwonder
This solution is clean and elegant, much appreciated!

AndrewKushnir added a commit that referenced this pull request Dec 5, 2019
AndrewKushnir added a commit that referenced this pull request Dec 5, 2019
AndrewKushnir added a commit that referenced this pull request Dec 5, 2019
…PipeSymbol.selectSignature (#34177)

PR Close #34177
AndrewKushnir added a commit that referenced this pull request Dec 5, 2019
AndrewKushnir added a commit that referenced this pull request Dec 5, 2019
AndrewKushnir added a commit that referenced this pull request Dec 5, 2019
…PipeSymbol.selectSignature (#34177)

PR Close #34177
josephperrott added a commit to josephperrott/angular that referenced this pull request Dec 11, 2019
josephperrott added a commit to josephperrott/angular that referenced this pull request Dec 11, 2019
josephperrott added a commit to josephperrott/angular that referenced this pull request Dec 11, 2019
josephperrott added a commit to josephperrott/angular that referenced this pull request Dec 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.