Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): pin terser to 4.4.0 #34179

Closed

Conversation

@alan-agius4
Copy link
Contributor

alan-agius4 commented Dec 2, 2019

4.4.1 caused a regression terser/terser#527 which is breaking our CI with such errors

'http://localhost:4200/main.57ce335e666ac98d65ad.js 0:370275 TypeError: e is not a function

Example of failing build https://circleci.com/gh/angular/angular/549169?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link

@googlebot googlebot added the cla: yes label Dec 2, 2019
@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-schematics-terser branch from 6a23043 to 69d75a0 Dec 2, 2019
@@ -59,7 +59,7 @@ function addDevDependenciesToPackageJson(options: Schema) {
'rollup': '^1.25.2',
'rollup-plugin-commonjs': '^10.1.0',
'rollup-plugin-node-resolve': '^5.2.0',
'terser': '^4.3.9',
'terser': '4.4.0',

This comment has been minimized.

Copy link
@gkalpak

gkalpak Dec 2, 2019

Member

Just to make sure I understand correctly, is this only needed in case we publish a @angular/bazel version before terser 4.4.2 is released, right?

Once 4.4.2 is released, should this be changed to ^4.4.2 again?

This comment has been minimized.

Copy link
@alan-agius4

alan-agius4 Dec 2, 2019

Author Contributor

Yes

integration/bazel-schematics/package.json Outdated Show resolved Hide resolved
@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-schematics-terser branch 2 times, most recently from 7eb5071 to c456fe0 Dec 2, 2019
4.4.1 caused a regression terser/terser#527 which is breaking our CI with such errors:
```
http://localhost:4200/main.57ce335e666ac98d65ad.js 0:370275 TypeError: e is not a function
```

Example of failing build https://circleci.com/gh/angular/angular/549169?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
@alan-agius4 alan-agius4 force-pushed the alan-agius4:bazel-schematics-terser branch from c456fe0 to e1d321d Dec 2, 2019
@alan-agius4 alan-agius4 marked this pull request as ready for review Dec 2, 2019
@alan-agius4 alan-agius4 requested review from angular/fw-integration as code owners Dec 2, 2019
@gkalpak
gkalpak approved these changes Dec 2, 2019
Copy link
Member

josephperrott left a comment

LGTM

@alan-agius4

This comment has been minimized.

Copy link
Contributor Author

alan-agius4 commented Dec 2, 2019

It seems that terser fixed the bug terser/terser#527

Thus, I am going to close this as it's no longer needed.

@alan-agius4 alan-agius4 closed this Dec 2, 2019
@alan-agius4 alan-agius4 deleted the alan-agius4:bazel-schematics-terser branch Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.