Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.
Sign upfix(bazel): pin terser to 4.4.0 #34179
Closed
Conversation
alan-agius4
force-pushed the
alan-agius4:bazel-schematics-terser
branch
from
6a23043
to
69d75a0
alan-agius4
force-pushed the
alan-agius4:bazel-schematics-terser
branch
from
69d75a0
to
189ee74
| @@ -59,7 +59,7 @@ function addDevDependenciesToPackageJson(options: Schema) { | |||
| 'rollup': '^1.25.2', | |||
| 'rollup-plugin-commonjs': '^10.1.0', | |||
| 'rollup-plugin-node-resolve': '^5.2.0', | |||
| 'terser': '^4.3.9', | |||
| 'terser': '4.4.0', | |||
This comment has been minimized.
This comment has been minimized.
gkalpak
Dec 2, 2019
Member
Just to make sure I understand correctly, is this only needed in case we publish a @angular/bazel version before terser 4.4.2 is released, right?
Once 4.4.2 is released, should this be changed to ^4.4.2 again?
This comment has been minimized.
This comment has been minimized.
alan-agius4
force-pushed the
alan-agius4:bazel-schematics-terser
branch
2 times, most recently
from
7eb5071
to
c456fe0
4.4.1 caused a regression terser/terser#527 which is breaking our CI with such errors: ``` http://localhost:4200/main.57ce335e666ac98d65ad.js 0:370275 TypeError: e is not a function ``` Example of failing build https://circleci.com/gh/angular/angular/549169?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
alan-agius4
force-pushed the
alan-agius4:bazel-schematics-terser
branch
from
c456fe0
to
e1d321d
This was referenced Dec 2, 2019
|
LGTM |
This comment has been minimized.
This comment has been minimized.
|
It seems that terser fixed the bug terser/terser#527 Thus, I am going to close this as it's no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
alan-agius4 commentedDec 2, 2019
•
edited
4.4.1 caused a regression terser/terser#527 which is breaking our CI with such errors
Example of failing build https://circleci.com/gh/angular/angular/549169?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link