Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bazel): don't rely on @angular/core being as a depedency to insta… #34181

Closed
wants to merge 1 commit into from

Conversation

@alan-agius4
Copy link
Contributor

alan-agius4 commented Dec 2, 2019

fix(bazel): don't rely on @angular/core being as a depedency to install @angular/bazel

With this change we fix the logic to detect if a package is installed, removing a package and add a package by using the CLI schematic helpers.

Also we save @angular/bazel package directly as a devDependency when doing ng-add.

Closes #34164

…ll @angular/bazel

With this change we fix the logic to detect if a package is installed, removing a package and add a package by using the CLI schematic helpers.

Also we save `@angular/bazel` package directly as a `devDependency` when doing `ng-add`.

Closes #34164
@alan-agius4 alan-agius4 requested a review from angular/tools-bazel as a code owner Dec 2, 2019
@googlebot googlebot added the cla: yes label Dec 2, 2019
@kyliau
kyliau approved these changes Dec 2, 2019

const angularCoreNode = findPropertyInAstObject(deps, '@angular/core');
if (!angularCoreNode) {
const angularCore = getPackageJsonDependency(host, '@angular/core');

This comment has been minimized.

Copy link
@kyliau

kyliau Dec 2, 2019

Member

Could you please add a comment here how this solves #34164 ?

This comment has been minimized.

Copy link
@alan-agius4

alan-agius4 Dec 2, 2019

Author Contributor

Because this method checks all type of dependencies. Previously only dependencies were being handled correctly.

mhevery added a commit that referenced this pull request Dec 2, 2019
…ll @angular/bazel (#34181)

With this change we fix the logic to detect if a package is installed, removing a package and add a package by using the CLI schematic helpers.

Also we save `@angular/bazel` package directly as a `devDependency` when doing `ng-add`.

Closes #34164

PR Close #34181
@mhevery mhevery closed this in 0cd8431 Dec 2, 2019
@alan-agius4 alan-agius4 deleted the alan-agius4:bazel-add-dev-dep branch Dec 2, 2019
@angular-automatic-lock-bot

This comment has been minimized.

Copy link

angular-automatic-lock-bot bot commented Jan 2, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants
You can’t perform that action at this time.