Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: clarify differential load doc #34189

Closed
wants to merge 3 commits into from

Conversation

@jbogarthyde
Copy link
Contributor

jbogarthyde commented Dec 2, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.io application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

https://angular.io/guide/deployment#differential-loading is confusing.

Issue Number: #32978

What is the new behavior?

Remove redundancy, edit and organize for clarity, conform to style guidelines for identifying examples/code snippets

Does this PR introduce a breaking change?

  • Yes
  • No
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 2, 2019

@jbogarthyde jbogarthyde requested a review from gkalpak Dec 2, 2019
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 2, 2019

Copy link
Member

gkalpak left a comment

I left a couple of comments for obvious things/typos I noticed, but someone from fw-docs-packaging or the cli team should verify the content.

aio/content/guide/deployment.md Outdated Show resolved Hide resolved
aio/content/guide/deployment.md Outdated Show resolved Hide resolved
aio/content/guide/deployment.md Outdated Show resolved Hide resolved
aio/content/guide/deployment.md Outdated Show resolved Hide resolved
@mary-poppins

This comment has been minimized.

Copy link

mary-poppins commented Dec 2, 2019

@jbogarthyde jbogarthyde requested a review from alan-agius4 Dec 2, 2019
Copy link
Contributor

alan-agius4 left a comment

LGTM

@jbogarthyde jbogarthyde moved this from In Review to Waiting for Approval in docs Dec 2, 2019
@jbogarthyde jbogarthyde requested a review from clydin Dec 3, 2019
@mhevery mhevery closed this in f84f362 Dec 3, 2019
mhevery added a commit that referenced this pull request Dec 3, 2019
PR Close #34189
@jbogarthyde jbogarthyde deleted the jbogarthyde:jb-e5-build branch Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.