Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(docs-infra): add deprecated-api-item class to remaining deprecated items #34192
Please check if your PR fulfills the following requirements:
What kind of change does this PR introduce?
What is the current behavior?
Deprecated items are not striked through
Issue Number: #31455
What is the new behavior?
Deprecated Items are stroked through
Does this PR introduce a breaking change?
gkalpak left a comment
Looks reasonable. Do we know of any examples where these changes actually make a difference (i.e. deprecated stuff that would not show up correctly without these changes)?
@gkalpak I'm attaching images for reference where it removes deprecated items. I've given both examples where it was not done earlier and now it's done. https://pr34192-45f36de.ngbuilds.io/api/core/Testability you can check this link for details.
@gkalpak So, should I add strikethrough to the headings or it is just fine. For me both are fine but what do you think is correct because right now as I see in the documentation we strike through the signature not the headings. Please suggest the correct way.